From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC659C47247 for ; Tue, 5 May 2020 20:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1F7320735 for ; Tue, 5 May 2020 20:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgEEU6D (ORCPT ); Tue, 5 May 2020 16:58:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:44922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbgEEU6D (ORCPT ); Tue, 5 May 2020 16:58:03 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 067EAACB8; Tue, 5 May 2020 20:58:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 05 May 2020 22:58:01 +0200 From: Roman Penyaev To: Andrew Morton Cc: Jason Baron , Khazhismel Kumykov , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1] epoll: call final ep_events_available() check under the lock In-Reply-To: <20200505130357.04566dee5501c3787105376f@linux-foundation.org> References: <20200505084049.1779243-1-rpenyaev@suse.de> <20200505130357.04566dee5501c3787105376f@linux-foundation.org> Message-ID: <35b7d79b5cc7ee5befb1e632043701a7@suse.de> X-Sender: rpenyaev@suse.de User-Agent: Roundcube Webmail Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2020-05-05 22:03, Andrew Morton wrote: > On Tue, 05 May 2020 10:42:05 +0200 Roman Penyaev > wrote: > >> May I ask you to remove "epoll: ensure ep_poll() doesn't miss wakeup >> events" from your -mm queue? Jason lately found out that the patch >> does not fully solve the problem and this one patch is a second >> attempt to do things correctly in a different way (namely to do >> the final check under the lock). Previous changes are not needed. > > Where do we stand with Khazhismel's "eventpoll: fix missing wakeup for > ovflist in ep_poll_callback"? > > http://lkml.kernel.org/r/20200424190039.192373-1-khazhy@google.com This one from Khazhismel is needed. Others are complementary to the Khazhismel's, except the "epoll: ensure ep_poll() doesn't miss wakeup events", which you've already removed. Thanks. -- Roman