From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH] aio: Check for aio_flags
Date: Wed, 8 Feb 2017 05:19:52 -0600 [thread overview]
Message-ID: <36d7d6b0-71ec-4c85-0256-d62c7a111cc8@suse.de> (raw)
In-Reply-To: <20170208075930.GA32505@infradead.org>
On 02/08/2017 01:59 AM, Christoph Hellwig wrote:
> On Tue, Feb 07, 2017 at 08:33:23PM -0600, Goldwyn Rodrigues wrote:
>> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>>
>> aio_flags are not checked when performing io_submit() and
>> can contain non-conforming values.
>> Return -EINVAL if they are invalid.
>
> while this is what we should have done from the start it could break
> existing userspace programs now.
>
Yes, I agree. it would be the one's who are using it incorrectly and
have been certified to work. However, I did run it through LTP and it
passed the tests (I understand it does not represent all of userspace
programs). We would need to correct behavior at some point in time
hoping not many depend on it.
Besides, this would also restrict expansion of aio_flags, which I intend
to do... (yeah, you see my ulterior motive now ;))
--
Goldwyn
prev parent reply other threads:[~2017-02-08 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 2:33 [PATCH] aio: Check for aio_flags Goldwyn Rodrigues
2017-02-08 7:59 ` Christoph Hellwig
2017-02-08 11:19 ` Goldwyn Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36d7d6b0-71ec-4c85-0256-d62c7a111cc8@suse.de \
--to=rgoldwyn@suse.de \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).