From: Bob Peterson <rpeterso@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 04/14] xfs: reorder zeroing and flushing sequence in truncate
Date: Thu, 5 May 2016 13:34:50 -0400 (EDT) [thread overview]
Message-ID: <378179150.1999179.1462469690382.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1462310947-16132-5-git-send-email-hch@lst.de>
----- Original Message -----
> Currently zeroing out blocks and waiting for writeout is a bit of a mess in
> truncate. This patch gives it a clear order in preparation for the iomap
> path:
>
> (1) we first wait for any direct I/O to complete to prevent any races
> for it
> (2) we then perform the actual zeroing, and only use the truncate_page
> helpers for truncating down. The truncate up case already is
> handled by the separate call to xfs_zero_eof.
> (3) only then we write back dirty data, as zeroing block may cause
> dirty pages when using either xfs_zero_eof or the new iomap
> infrastructure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> + * Start with zeroing any data beyond EOF that we may expose on file
> + & extension, or zeroing out the rest of the block on a downward
This "&" should be "*".
Reviewed-by: Bob Peterson <rpeterso@redhat.com>
next prev parent reply other threads:[~2016-05-05 17:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 21:28 iomap infrastructure and multipage writes V3 Christoph Hellwig
2016-05-03 21:28 ` [PATCH 01/14] fs: move struct iomap from exportfs.h to a separate header Christoph Hellwig
2016-05-05 17:27 ` Bob Peterson
2016-05-03 21:28 ` [PATCH 02/14] fs: introduce iomap infrastructure Christoph Hellwig
2016-05-05 17:32 ` Bob Peterson
2016-05-03 21:28 ` [PATCH 03/14] xfs: make xfs_bmbt_to_iomap available outside of xfs_pnfs.c Christoph Hellwig
2016-05-05 17:33 ` Bob Peterson
2016-05-03 21:28 ` [PATCH 04/14] xfs: reorder zeroing and flushing sequence in truncate Christoph Hellwig
2016-05-05 17:34 ` Bob Peterson [this message]
2016-05-03 21:28 ` [PATCH 05/14] xfs: implement iomap based buffered write path Christoph Hellwig
2016-05-05 17:55 ` Bob Peterson
2016-05-03 21:28 ` [PATCH 06/14] xfs: remove buffered write support from __xfs_get_blocks Christoph Hellwig
2016-05-05 17:57 ` Bob Peterson
2016-05-03 21:29 ` [PATCH 07/14] fs: iomap based fiemap implementation Christoph Hellwig
2016-05-03 21:29 ` [PATCH 08/14] xfs: use iomap " Christoph Hellwig
2016-05-03 21:29 ` [PATCH 09/14] iomap: support DAX based zeroing Christoph Hellwig
2016-05-03 21:29 ` [PATCH 10/14] xfs: use iomap infrastructure for DAX zeroing Christoph Hellwig
2016-05-03 21:29 ` [PATCH 11/14] xfs: handle 64-bit length in xfs_iozero Christoph Hellwig
2016-05-03 21:29 ` [PATCH 12/14] xfs: use xfs_zero_range in xfs_zero_eof Christoph Hellwig
2016-05-03 21:29 ` [PATCH 13/14] xfs: split xfs_free_file_space in manageable pieces Christoph Hellwig
2016-05-03 21:29 ` [PATCH 14/14] xfs: kill xfs_zero_remaining_bytes Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378179150.1999179.1462469690382.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).