From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2 0/2] Add further ioctl() operations for namespace discovery To: "Eric W. Biederman" References: <93e5c7f9-9dc1-6c93-ad20-0ba053d8bfef@gmail.com> <87a8aggjx5.fsf@xmission.com> Cc: mtk.manpages@gmail.com, "Serge E. Hallyn" , Linux API , lkml , "linux-fsdevel@vger.kernel.org" , Andrey Vagin , James Bottomley , "W. Trevor King" , Alexander Viro From: "Michael Kerrisk (man-pages)" Message-ID: <38ec76ed-8f4c-b0be-b144-d17ffd1ae0c1@gmail.com> Date: Wed, 25 Jan 2017 13:39:01 +1300 MIME-Version: 1.0 In-Reply-To: <87a8aggjx5.fsf@xmission.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hello Eric, On 01/25/2017 11:41 AM, Eric W. Biederman wrote: > "Michael Kerrisk (man-pages)" writes: > >> Hi Eric, >> >> Do you have any input for this small patch set? I've still to tweak a >> comment as suggested by Trevor King, but otherwise I'd like to know if >> this is good to go for the next merge window. > > Apologies I have been bogged down with other things. Basically the > code looks fine, and now that I have caught up with things I will be > happy to merge your for the next merge window. Thanks. > I do wonder if returning -EOVERFLOW may be more useful than running > the overflow_uid when mapping fails. Yes, it I think you're right. I'll fix that. > Also, now that I think about it. Please let's use (uid_t __user *) for > the type of argp. I think that will be more maintainable in the long > run. Easier to grep for etc. Yes, I'll make that change. > Neither of these things are big or would prevent me from merging your > change just things that I think would be nice to have. Both seem worth having to me. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/