From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fengguang Wu Subject: Re: + reiserfs-dont-drop-pg_dirty-when-releasing-sub-page-sized-dirty-file .patch added to -mm tree Date: Thu, 25 Oct 2007 10:37:08 +0800 Message-ID: <393279833.15570@ustc.edu.cn> References: <200710242307.l9ON7btk017173@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mm-commits@vger.kernel.org, chris.mason@oracle.com, jeffm@suse.com, maximlevitsky@gmail.com, peterz@infradead.org, stable@kernel.org, lkml , linux-fsdevel@vger.kernel.org To: akpm@linux-foundation.org Return-path: Received: from smtp.ustc.edu.cn ([202.38.64.16]:58103 "HELO ustc.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1753656AbXJYChM (ORCPT ); Wed, 24 Oct 2007 22:37:12 -0400 Content-Disposition: inline In-Reply-To: <200710242307.l9ON7btk017173@imap1.linux-foundation.org> Message-Id: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Oct 24, 2007 at 04:07:37PM -0700, akpm@linux-foundation.org wrote: > > The patch titled > reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file > has been added to the -mm tree. Its filename is > reiserfs-dont-drop-pg_dirty-when-releasing-sub-page-sized-dirty-file.patch > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > out what to do about this > > ------------------------------------------------------ > Subject: reiserfs: don't drop PG_dirty when releasing sub-page-sized dirty file > From: Fengguang Wu > > This is not a new problem in 2.6.23-git17. 2.6.22/2.6.23 is buggy in the > same way. > > Reiserfs could accumulate dirty sub-page-size files until umount time. > They cannot be synced to disk by pdflush routines or explicit `sync' ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Sorry it's not that horrible. The *data* will still be written to disk. Only the inodes will be stuck in I_DIRTY_PAGES state, and the pages stuck in PAGECACHE_TAG_DIRTY state. > commands. Only `umount' can do the trick. > > The direct cause is: the dirty page's PG_dirty is wrongly _cleared_. > Call trace: > [] cancel_dirty_page+0xd0/0xf0 > [] :reiserfs:reiserfs_cut_from_item+0x660/0x710 > [] :reiserfs:reiserfs_do_truncate+0x271/0x530 > [] :reiserfs:reiserfs_truncate_file+0xfd/0x3b0 > [] :reiserfs:reiserfs_file_release+0x1e0/0x340 > [] __fput+0xcc/0x1b0 > [] fput+0x16/0x20 > [] filp_close+0x56/0x90 > [] sys_close+0xad/0x110 > [] system_call+0x7e/0x83 > > Fix the bug by removing the cancel_dirty_page() call. Tests show that > it causes no bad behaviors on various write sizes.