From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CAE81D094D for ; Wed, 2 Oct 2024 15:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727881214; cv=none; b=Fg/iA8BUAcIjflIpvOIdBMsLb6/2KxjQu5SnexQlSfB75N4IGJFIJIWQtFjscHVdkChfwBgUfzJBNMIfzCFAvCreaJz9CS30u/xb7ltRZsHXNHddM/smywXgB6jJ3QTpB5QU+ioIqUgmzEE5vfQt2jgt14q+0fQgikAlU6h5L0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727881214; c=relaxed/simple; bh=vl7wyuQQoK4XYBeXABxAwPJIzjHZQ1aU5cX46VnQpKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EnSM2piZBr0/xDHdDup4MQCVXV8NeoL/zbT5zP/P+KaqYtK7wT/angx8GVK08VRI5wEOymJbFwFdJTb6b4nVRtF8SdyZLPNOb1J7UfVEANOqiJixAOnJ7e4/MRnbQMRHHegc05CXh6dVRAwSvEc2xk28MJtmI3ICBhzC3X7+6T4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=IiZlTaLY; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="IiZlTaLY" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-83493f2dda4so33657039f.1 for ; Wed, 02 Oct 2024 08:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727881212; x=1728486012; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0ATO5nzXBRKuk5zIyka26b7+2X+oqvRAeNDNerUiZPQ=; b=IiZlTaLYj714KdThD/EflxMCjc5uKOh5DKebGte87JmacTiyDGXsPPN7D3PJvdyO8q JARrPVJOad7bJWNJPgHGtwxJf7eI/FDg2/SnWZ9mV/cHF1XNM4fJ4IH/YFhXvEhqj6N0 4Ktcn714j3DiTxMy8Dtl0fb9TU2D3gOw7hsb/Gko0WQHuAmR9sddq819jAnXlA1vE5sF JRdwgRZ3EFhgh0alCdkpMYZvu+/DnDgpsKyCcQZh1xm3AmN8wy9fxDnyE+M407Xxz2eY 37LenNAJ9SZkcLJAm0CC7eBcVv0Y5ke1taAan3PqWldz/y5m443l3U9K+eO2VnWrWbmk Ssgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727881212; x=1728486012; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0ATO5nzXBRKuk5zIyka26b7+2X+oqvRAeNDNerUiZPQ=; b=n/F6Hvab+hkdvk6Y9w3eh2XRxAufTGFqu3Gx6bz5Zbs5gUuqj3jlsFB7hyK9b0BD9V B0BcrrzEKVBHUhmCW75LBlIpmYB5R5SfRmlTIUCNp3lIxNcdcBwzQh4xnrSMBtyU8RNV UO4hoI8QBTZ/JLn/s3nzUVBLnYqhkAt0sogHtdQHk7gTAYD9ksuPJ54FXASzv0b7lxqq VQdCv66kusLWWn2zFRw2d/bwIkTNqWA+HwTorq7fH2L1IkRcYzroqqxgdojbIaFwrG4Z nbkFO8MkAo2CkR34s8n+Advp7FJkl+PgZBwZLpmL1HBH6xv47N6mRuEy52RnQ8WPUohM X9Fg== X-Forwarded-Encrypted: i=1; AJvYcCVV4zcI+UIrPJO+SULuVyThaGnSt4TTsLQ6EXjuQbcckbnn2SPO8OXCsxDyoswgzB+wCVbzhha1hIgYleI+@vger.kernel.org X-Gm-Message-State: AOJu0YzFjoaUa7lFJgA5O2eJU459A4zJ8krVBiaF8SXjdmgvNcxIIHEg fscprd3nrrgjxDp+PM6PwMw81Iqkwr5TEbctCw21MvPO5pqUjA6pv312y57eoIg= X-Google-Smtp-Source: AGHT+IHex8HS6m/uMgtGBHqHA7E/dbDjbWiTPY1GdyYsbd449LVjuZyZTpNsMhmhRF47klqBZJ3/jg== X-Received: by 2002:a05:6e02:1a4c:b0:39d:3c87:1435 with SMTP id e9e14a558f8ab-3a35eb0211dmr53524285ab.1.1727881211298; Wed, 02 Oct 2024 08:00:11 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d8888f9d33sm3158793173.163.2024.10.02.08.00.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Oct 2024 08:00:10 -0700 (PDT) Message-ID: <397fe31d-413d-4ef7-ab56-0a7b3b51d79a@kernel.dk> Date: Wed, 2 Oct 2024 09:00:09 -0600 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/3] FDP and per-io hints To: Keith Busch , Christoph Hellwig Cc: Kanchan Joshi , hare@suse.de, sagi@grimberg.me, martin.petersen@oracle.com, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, bcrl@kvack.org, dhowells@redhat.com, bvanassche@acm.org, asml.silence@gmail.com, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com References: <20240930181305.17286-1-joshi.k@samsung.com> <20241001092047.GA23730@lst.de> <20241002074926.GA20819@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/2/24 8:56 AM, Keith Busch wrote: > On Wed, Oct 02, 2024 at 09:49:26AM +0200, Christoph Hellwig wrote: >> On Tue, Oct 01, 2024 at 10:23:43AM -0600, Keith Busch wrote: >>> I think because he's getting conflicting feedback. The arguments against >>> it being that it's not a good match, however it's the same match created >>> for streams, and no one complained then, and it's an existing user ABI. >> >> People complained, and the streams code got removed pretty quickly >> because it did not work as expected. I don't think that counts as >> a big success. > > I don't think the kernel API was the problem. Capable devices never > materialized, so the code wasn't doing anything useful. Exactly. I never saw ones that kept the stream persistent across GC, and hence they ended up being pretty useless in practice. -- Jens Axboe