From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-b1-smtp.messagingengine.com (flow-b1-smtp.messagingengine.com [202.12.124.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD99288530; Thu, 2 Oct 2025 23:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.136 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759447213; cv=none; b=p2bQPuwC/u9KevDZ3EAXC4W+J4uwW1Jb3j8nFmg1oV0NH5+wpRUJZ1kRHKR00OTa1w3a6IccgPOevQafD6J8mDa+Z5vuFdXSukCrzfYZrogWsqj4OC1+EUHZNDzCEiVNQyhjy7m+18AwkLyQaGkwOzcP1I5o84PonqJlhpM1IvE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759447213; c=relaxed/simple; bh=BR/jqWo92itmdMH1ocfUuKDAP7WulChibnIwAiSXhT4=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=As55O0BgHHu7XadPt6rE8gWYgT1KYrbqPzeVZGWgC5JFMIasraf95uQ+Xd16EXZcK4J5Z1KOPYSUcJZhHASyGrDj5IfenDbmLy4YpVNuJ7mk1Frg/O0JkIGOztW6eK+6l2sWg+PLUHk+LTAtWw4lg/mSmQe2zIAawEffjygT5Jc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=UlZXQBIH; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=UPWCT2uX; arc=none smtp.client-ip=202.12.124.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="UlZXQBIH"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="UPWCT2uX" Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.stl.internal (Postfix) with ESMTP id DB1F41300343; Thu, 2 Oct 2025 19:20:09 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-04.internal (MEProxy); Thu, 02 Oct 2025 19:20:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1759447209; x=1759454409; bh=8eLJoj9XRO384G/VvXT2HeFOAWEdoc6vPNt14uKR73A=; b= UlZXQBIHPI3UaJe+qvjb/0azu1Oe5qtfVSOgfR9F74ejhfdVcoLT5yCscAFxGXg8 pwym4mpSChHvERlZa3eyvyx08BV44zMw3YGN0tM+vPnhSUz76Sq/1sLgdMvN//1t MgHWqimhr0AzYrwUzdnliiWe0Dm9Z34Ogn+/sldz60VOggZ3d7nAO9W0sjAS+ODa YJDWUIJqUD3rBGsCWCRyC9s7i9AA9pS/qByHexvhH8G1gQsu2dD8k1LeI24HGUWh /03Dje8K6N7L4VyDIt3NIojzwr6tdgIOBwfeBK5umF7roU56mWwwY3FulE7R0j2n QUpOkKf5lBp7bdgkzhLbPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1759447209; x= 1759454409; bh=8eLJoj9XRO384G/VvXT2HeFOAWEdoc6vPNt14uKR73A=; b=U PWCT2uXT/GxiygPtmHbccRddiUfCEYjhtJdXJccb/5YerEHrZjTt4d9N2RDQu1Wk qyOu+HowFfq+mSzSu4jBKZpxK4j61odikvauJS62BQvPo05HzMc2V0Q02lDG/KuV xFOFsUSRnUOVxEuk/jp9b7DJX/6hFCwfMhDmrQ+Gjgp+bzUnTy9kM9MFcHK3eQR5 T9dRhCCh7CnFM2shDd7H9AIA40TS7O85KP3muQgcpbkTId7BGzFMnUMJQzEW6cKC RXT0xfdCbnheksb/9HE80aFjG/+J9g7pqLK4D083rrfitbbZ+Xq2jg/7x8JM1H12 rJ7EgoklB90Zb+f1OtOPw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdekjeefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhnugcu uegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtthgvrh hnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffgvedugeduveelvdekhfdvieen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnug esrghrnhgusgdruggvpdhnsggprhgtphhtthhopeegledpmhhouggvpehsmhhtphhouhht pdhrtghpthhtohepughrihdquggvvhgvlheslhhishhtshdrfhhrvggvuggvshhkthhoph drohhrghdprhgtphhtthhopehlihhnuhigqdgrrhhmqdhkvghrnhgvlheslhhishhtshdr ihhnfhhrrgguvggrugdrohhrghdprhgtphhtthhopehlihhnrghrohdqmhhmqdhsihhgse hlihhsthhsrdhlihhnrghrohdrohhrghdprhgtphhtthhopehlihhnuhigqdhrthdquggv vhgvlheslhhishhtshdrlhhinhhugidruggvvhdprhgtphhtthhopegtohhrsggvtheslh ifnhdrnhgvthdprhgtphhtthhopehthihtshhosehmihhtrdgvughupdhrtghpthhtohep jhhovghlrghgnhgvlhhfsehnvhhiughirgdrtghomhdprhgtphhtthhopeiiihihsehnvh hiughirgdrtghomhdprhgtphhtthhopegurghmihgvnhdrlhgvmhhorghlsehophgvnhhs ohhurhgtvgdrfigutgdrtghomh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 38369700065; Thu, 2 Oct 2025 19:20:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: Aghr8S2aY07B Date: Fri, 03 Oct 2025 01:19:33 +0200 From: "Arnd Bergmann" To: "Mathieu Desnoyers" , "Greg Kroah-Hartman" , "Byungchul Park" Cc: linux-kernel@vger.kernel.org, kernel_team@skhynix.com, "Linus Torvalds" , "Damien Le Moal" , linux-ide@vger.kernel.org, "Andreas Dilger" , linux-ext4@vger.kernel.org, "Ingo Molnar" , "Peter Zijlstra" , "Will Deacon" , "Thomas Gleixner" , "Steven Rostedt" , "Joel Fernandes" , "Sasha Levin" , "Daniel Vetter" , duyuyang@gmail.com, "Johannes Berg" , "Tejun Heo" , "Theodore Ts'o" , "Matthew Wilcox" , "Dave Chinner" , "Amir Goldstein" , kernel-team@lge.com, linux-mm@kvack.org, "Andrew Morton" , "Michal Hocko" , "Minchan Kim" , "Johannes Weiner" , vdavydov.dev@gmail.com, "SeongJae Park" , jglisse@redhat.com, "Dennis Zhou" , "Christoph Lameter" , "Pekka Enberg" , "David Rientjes" , "Vlastimil Babka" , ngupta@vflare.org, linux-block@vger.kernel.org, "Josef Bacik" , linux-fsdevel@vger.kernel.org, "Jan Kara" , "Jeff Layton" , "Dan Williams" , "Christoph Hellwig" , "Darrick J. Wong" , dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, "Gwan-gyeong Mun" , max.byungchul.park@gmail.com, "Boqun Feng" , "Waiman Long" , yunseong.kim@ericsson.com, ysk@kzalloc.com, "Yeoreum Yun" , Netdev , "Matthew Brost" , her0gyugyu@gmail.com, "Jonathan Corbet" , "Catalin Marinas" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Andy Lutomirski" , "Sumit Semwal" , gustavo@padovan.org, =?UTF-8?Q?Christian_K=C3=B6nig?= , "Andi Shyti" , "Lorenzo Stoakes" , "Liam R. Howlett" , "Mike Rapoport" , "Suren Baghdasaryan" , "Luis Chamberlain" , "Petr Pavlu" , da.gomez@kernel.org, "Sami Tolvanen" , "Paul E. McKenney" , "Frederic Weisbecker" , neeraj.upadhyay@kernel.org, joelagnelf@nvidia.com, "Josh Triplett" , "Uladzislau Rezki (Sony)" , "Lai Jiangshan" , qiang.zhang@linux.dev, "Juri Lelli" , "Vincent Guittot" , "Dietmar Eggemann" , "Benjamin Segall" , "Mel Gorman" , "Valentin Schneider" , "Chuck Lever" , neil@brown.name, okorniev@redhat.com, "Dai Ngo" , "Tom Talpey" , trondmy@kernel.org, "Anna Schumaker" , "Kees Cook" , "Sebastian Andrzej Siewior" , "Clark Williams" , "Mark Rutland" , ada.coupriediaz@arm.com, kristina.martsenko@arm.com, "Kefeng Wang" , "Mark Brown" , "Kevin Brodsky" , "David Woodhouse" , "Shakeel Butt" , "Alexei Starovoitov" , "Zi Yan" , "Yu Zhao" , "Baolin Wang" , usamaarif642@gmail.com, joel.granados@kernel.org, "Wei Yang" , "Geert Uytterhoeven" , tim.c.chen@linux.intel.com, linux , "Alexander Shishkin" , lillian@star-ark.net, "Huacai Chen" , francesco@valla.it, guoweikang.kernel@gmail.com, link@vivo.com, "Josh Poimboeuf" , "Masahiro Yamada" , "Christian Brauner" , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , "Oleg Nesterov" , "Mateusz Guzik" , "Andrii Nakryiko" , wangfushuai@baidu.com, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-i2c@vger.kernel.org, Linux-Arch , linux-modules@vger.kernel.org, rcu , linux-nfs@vger.kernel.org, linux-rt-devel@lists.linux.dev Message-Id: <3bbe14af-ccdc-4c78-a7ca-d4ed39fa6b5d@app.fastmail.com> In-Reply-To: <63034035-03e4-4184-afce-7e1a897a90e9@efficios.com> References: <20251002081247.51255-1-byungchul@sk.com> <20251002081247.51255-2-byungchul@sk.com> <2025100230-grafted-alias-22a2@gregkh> <63034035-03e4-4184-afce-7e1a897a90e9@efficios.com> Subject: Re: [PATCH v17 01/47] llist: move llist_{head,node} definition to types.h Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Oct 2, 2025, at 15:53, Mathieu Desnoyers wrote: > On 2025-10-02 04:24, Greg KH wrote: >> On Thu, Oct 02, 2025 at 05:12:01PM +0900, Byungchul Park wrote: >>> llist_head and llist_node can be used by some other header files. For >>> example, dept for tracking dependencies uses llist in its header. To >>> avoid header dependency, move them to types.h. >> >> If you need llist in your code, then include llist.h. Don't force all >> types.h users to do so as there is not a dependency in types.h for >> llist.h. >> >> This patch shouldn't be needed as you are hiding "header dependency" for >> other files. > > I agree that moving this into a catch-all types.h is not what we should > aim for. > > However, it's a good practice to move the type declarations to a > separate header file, so code that only cares about type and not > implementation of static inline functions can include just that. > > Perhaps we can move struct llist_head and struct llist_node to a new > include/linux/llist_types.h instead ? We have around a dozen types of linked lists, and the most common two of them are currently defined in linux/types.h, while the rest of them are each defined in the same header as the inteface definition. Duplicating each of those headers by splitting out the trivial type definition doesn't quite seem right either, as we'd end up with even more headers that have to be included indirectly in each compilation unit. Maybe a shared linux/list_types.h would work, to specifically contain all the list_head variants that are meant to be included in larger structures? Arnd