linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] fs/proc: introduce /proc/stat2 file
Date: Mon, 29 Oct 2018 16:29:59 -0400	[thread overview]
Message-ID: <3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com> (raw)
In-Reply-To: <20181029200050.iejuxckzbm742dmw@linux-r8p5>

On 10/29/2018 04:00 PM, Davidlohr Bueso wrote:
> On Mon, 29 Oct 2018, Waiman Long wrote:
>
>> I am wondering if /proc/stat_noirqs will be a more descriptive name of
>> the intent of this new procfs file or we should just go with the more
>> generic stat2 name.
>
> The reason why I went with '2' instead of a more rescriptive name
> was that I think of the call as a drop-in replacement/extention to
> stat. Therefore the same fields are maintained, otherwise with
> stat_noirqs
> I feel like instead of zeroing out, they should just be removed.
>
> But otoh, I have no strong objection in renaming either.
>
> Thanks,
> Davidlohr

I am just questioning the rationale for the stat2 name. I am not
advocating to use stat_noirqs neither.

BTW, since you are making stat2 compatible with stat, will that be
easier from the user API perspective if we use a sysctl parameter to
turn on and off IRQs reporting for /proc/stat, for example?

I know that there are pros and cons for each approach, I just want to
consider all the available options and choose the best one.

Cheers,
Longman

  reply	other threads:[~2018-10-30  5:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 19:25 [PATCH] fs/proc: introduce /proc/stat2 file Davidlohr Bueso
2018-10-29 19:35 ` Waiman Long
2018-10-29 20:00   ` Davidlohr Bueso
2018-10-29 20:29     ` Waiman Long [this message]
2018-10-29 20:38       ` Davidlohr Bueso
2018-10-29 20:59         ` Waiman Long
2018-10-29 21:23           ` Vito Caputo
2018-10-29 21:35             ` Waiman Long
2018-10-29 22:41               ` Vito Caputo
2018-10-30 18:57             ` Davidlohr Bueso
2018-10-30 22:40               ` Vito Caputo
2018-10-30 23:15                 ` Davidlohr Bueso
2018-10-29 21:01 ` Waiman Long
2018-10-29 23:04 ` Daniel Colascione
2018-10-30  0:58   ` Vito Caputo
2018-11-06 23:48   ` Andrew Morton
2018-11-07  3:32     ` Davidlohr Bueso
2018-11-07 16:31       ` Waiman Long
2018-11-07 10:03     ` Miklos Szeredi
2018-11-07 15:42       ` Daniel Colascione
2018-11-07 15:54         ` Miklos Szeredi
2018-11-07 16:01           ` Daniel Colascione
2018-11-07 20:32       ` Vito Caputo
2018-11-08  2:07       ` Dave Chinner
2018-11-08  7:24         ` Davidlohr Bueso
2018-11-08  7:44           ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c5ba85b-5114-c751-0114-ac2cb64c02ea@redhat.com \
    --to=longman@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).