From: "Yan Zheng" <yanzheng@21cn.com>
To: "Hugh Dickins" <hugh@veritas.com>
Cc: "Nick Piggin" <nickpiggin@yahoo.com.au>,
"Miklos Szeredi" <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages
Date: Tue, 9 Oct 2007 06:50:17 +0800 [thread overview]
Message-ID: <3d0408630710081550k430f50c1nae5097776358f1a0@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0710081418140.8640@blonde.wat.veritas.com>
2007/10/8, Hugh Dickins <hugh@veritas.com>:
> On Mon, 8 Oct 2007, Yan Zheng wrote:
> >
> > The test for VM_CAN_NONLINEAR always fails
> Good catch indeed. Though I was puzzled how we do nonlinear at all,
> until I realized it's "The test for not VM_CAN_NONLINEAR always fails".
> It's not as serious as it appears, since code further down has been
> added more recently to simulate nonlinear on non-RAM-backed filesystems,
> instead of going the real nonlinear way; so most filesystems are now not
> required to do what VM_CAN_NONLINEAR was put in to ensure they could do.
> I'm confused as to where that leaves us: is this actually a fix that
> needs to go into 2.6.23? or will it suddenly disable a system call
> which has been silently working fine on various filesystems which did
> not add VM_CAN_NONLINEAR? could we just rip out VM_CAN_NONLINEAR?
> I hope Nick or Miklos is clearer on what the risks are.
> (Apologies for all the "not"s and "non"s here, I'm embarrassed
> after just criticizing Ingo's SCHED_NO_NO_OMIT_FRAME_POINTER!)
> Hugh
Yes, I mean "The test for not VM_CAN_NONLINEAR always fails". please
forgive my poor English.
next prev parent reply other threads:[~2007-10-08 22:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 11:45 [PATCH]fix VM_CAN_NONLINEAR check in sys_remap_file_pages Yan Zheng
2007-10-08 11:52 ` WANG Cong
2007-10-08 13:37 ` Hugh Dickins
2007-10-08 6:47 ` Nick Piggin
2007-10-08 22:50 ` Yan Zheng [this message]
2007-10-08 17:04 ` Andrew Morton
2007-10-08 7:02 ` Nick Piggin
2007-10-08 17:28 ` Randy Dunlap
[not found] ` <20071008102843.d20b56d7.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2007-10-08 17:51 ` Andrew Morton
2007-10-08 7:45 ` Nick Piggin
2007-10-09 1:43 ` Yan Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d0408630710081550k430f50c1nae5097776358f1a0@mail.gmail.com \
--to=yanzheng@21cn.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).