From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from szxga02-in.huawei.com ([45.249.212.188]:2895 "EHLO
        dggrg02-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751115AbdBXJJ1 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 24 Feb 2017 04:09:27 -0500
Subject: Re: [PATCH 3/3] f2fs: provide more chance for node and data to get
 ssr segment
To: Jaegeuk Kim <jaegeuk@kernel.org>,
        Yunlong Song <yunlong.song@huawei.com>
References: <1487767851-819-1-git-send-email-yunlong.song@huawei.com>
 <1487767851-819-3-git-send-email-yunlong.song@huawei.com>
 <20170223011754.GH4003@jaegeuk.local>
CC: <chao@kernel.org>, <sylinux@163.com>, <miaoxie@huawei.com>,
        <bintian.wang@huawei.com>, <linux-fsdevel@vger.kernel.org>,
        <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
From: Chao Yu <yuchao0@huawei.com>
Message-ID: <3d4b064b-817f-402f-3eb5-df3ec7c06b44@huawei.com>
Date: Fri, 24 Feb 2017 17:05:28 +0800
MIME-Version: 1.0
In-Reply-To: <20170223011754.GH4003@jaegeuk.local>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi Jaegeuk,

Reviewed-by: Chao Yu <yuchao0@huawei.com>

For your attached two patches.

Thanks,

On 2017/2/23 9:17, Jaegeuk Kim wrote:
> Hi Yunlong,
> 
> I've been testing the similar patches as I attached.
> 
> Thanks,
> 
> On 02/22, Yunlong Song wrote:
>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>> ---
>>  fs/f2fs/segment.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 9d13743..5fe71b9 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>  {
>>  	struct curseg_info *curseg = CURSEG_I(sbi, type);
>>  	const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
>> +	int old_type = type;
>>  
>>  	if (IS_NODESEG(type)) {
>>  		for (; type >= CURSEG_HOT_NODE; type--)
>>  			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>  							BG_GC, type, SSR))
>>  				return 1;
>> +		for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++)
>> +			if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> +							BG_GC, type, SSR))
>> +				return 1;
>>  		return 0;
>>  	}
>>  
>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>  		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>  						BG_GC, type, SSR))
>>  			return 1;
>> +	for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++)
>> +		if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> +						BG_GC, type, SSR))
>> +			return 1;
>>  	return 0;
>>  }
>>  
>> -- 
>> 1.8.5.2