From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF293C761A6 for ; Wed, 29 Mar 2023 23:34:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbjC2XeF (ORCPT ); Wed, 29 Mar 2023 19:34:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjC2XeE (ORCPT ); Wed, 29 Mar 2023 19:34:04 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 779015251 for ; Wed, 29 Mar 2023 16:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132843; x=1711668843; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=GDXEDSyEMJWiW+7+O1GblQg3NUjwO7C813zV/2S0RGs=; b=XGIfQXr/I6GOdbNNGAphgzh/8v/TL3gR1CJblzaKoO4XHz9DCFjeGE+w Az+ydB4dyD+hidCKlxWCHv3FtLrCYRt4/dHDKUJqy8JjNfO7nlrAU7WX/ APQVKO7/ExLQS5d5+A7/jBMf/L/XEScCxJ6UZALMuccbz/PzTTYNXr9Az rNGG7SI6MXQUFkkN5b1Zd/3m4C4M12TefDt6IGD/HXuS15TCCknulth9L SmrvyJhxG4E/B1USAYES2qHtPGhnOd5IHCAVTKhkaO5x/y7LpVgWYekMz NmJAfLQ14HlTwpjq3VBJa96k9MK32OdAEQKjsixbF1iJQZyUW7rURoVYl w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648253" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:34:02 +0800 IronPort-SDR: s0HsGxYPvV5hcRVLkz3FTWfqgTFqhd0DK4go8YwoM67KLb9451rPdgFDz5geJtjNP8sC/RdDUw P1MxS4fl9HtKCpDNRtmI4sVmD/VLfZ7antbV74caMjhIaq9dlsLn9x5oq8W4AHN07glM5Pdu+l EeM32ZRhle8fw6Df4QAh0MfeLQtTA4D5a8hLEwSOf453NVpORgQTPIwRQDhTGuf4FIpEdycQ5v 8wN3p5NcwFprOHuhgrkVr3xYDjqVf6BiFloO846Y6+Q6FEncxrACmmyH65VuaSdDrPuoEz6ycw j8U= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:50:10 -0700 IronPort-SDR: qH6Jx6kQrB1LPozsHxPU1jUP9CP2sxx0GtwnYGEFLlqrVyrshZezL7G9OjvXCl74jc0s08ENtq 9Pspeg+pmKG2XupcQbrykrAgE7VGttF/HrNWGPQ0Z5pgASZ07P+vSb5WSkPQAkJ2ybXd8waMGL LnDdFgEq3vNhMvyr0/3I7BIoPjHWLhRKe+Jk6M32cl2hIJ5YKa++f3wGk6Vo5dMuf+JsfBDV43 YfVeolxGYpr0TPioIb39FLzQxgyolX1EOthnWrkss/gGiEkdzHgzGx2Q+iAKBT/olMM47VaQEf 7Sc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:34:02 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2tx3scVz1RtVq for ; Wed, 29 Mar 2023 16:34:01 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132840; x=1682724841; bh=GDXEDSyEMJWiW+7+O1GblQg3NUjwO7C813z V/2S0RGs=; b=Kl9kIAB48YMkB355tdUzMAD6Lq7A95Cb8NfzVQHNcITpVbKpz5Q Bf/AlRacy+pwRPXxv/Y59EYwdHDj+sTzoN5d7khiJg1/fGxSDSjw6dIQly/wyEJ2 ukCLhjTvrSGecTdk0ROBuOBGbsnuKbXyOPdM7YY2E4Dni8ehYMBTgPC7NIVoKJxc 8IKPtyMNTgTUJYWyKfuXjNsbQw0QIXDyQWwuAWgSMepI8V9fHAzLY/2GXcTCzi1T 8EIsd+WBdRLyK8+qPFbQ6B5xdnHCAUKseq3eKeeBNbs9gw2iB6jUvVdXetSvwOGq ede4DlUtPAZbbK7Xl0zEQL9cV4gZzJeC4yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1vxl6MJCFuVG for ; Wed, 29 Mar 2023 16:34:00 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2ts6Vtrz1RtVm; Wed, 29 Mar 2023 16:33:57 -0700 (PDT) Message-ID: <3f1c6faf-b558-14ba-a2bc-ac12aad41ba9@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:33:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 09/19] btrfs: raid56: use __bio_add_page to add single page Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: <5ce38530bc488f9d4f1692d701ca7ad5ea8ca3e9.1680108414.git.johannes.thumshirn@wdc.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <5ce38530bc488f9d4f1692d701ca7ad5ea8ca3e9.1680108414.git.johannes.thumshirn@wdc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 3/30/23 02:05, Johannes Thumshirn wrote: > The btrfs raid58 sector submission code uses bio_add_page() to add a page > to a newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research