From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E2BC4338F for ; Mon, 23 Aug 2021 06:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA4DB61250 for ; Mon, 23 Aug 2021 06:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234862AbhHWGZm (ORCPT ); Mon, 23 Aug 2021 02:25:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45627 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234206AbhHWGZl (ORCPT ); Mon, 23 Aug 2021 02:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629699898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fTBmg72UzrJzwwgyL0XX6MmGnq4XiN30FwOUg0WyeL8=; b=FP2I2eF6Vxj4C/mxETXrKldB7G93JIfxP2rg+iQuY6zkP7hxPWMnt/LYHoLJPesp5185TT 2M2WmoRjIDg1DTPRbPilW/A8x+plT6ZweSyMVBOdwaOXI8PutPBFnfXl31D/yohln3perb 4DnkMDSyWr8ktMsfO1ZigPp2uOdA4bU= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-205-1Uqc3TOXNZWcSXF7aWHl-g-1; Mon, 23 Aug 2021 02:24:56 -0400 X-MC-Unique: 1Uqc3TOXNZWcSXF7aWHl-g-1 Received: by mail-pg1-f200.google.com with SMTP id q22-20020a63e956000000b002524787adb1so9794520pgj.3 for ; Sun, 22 Aug 2021 23:24:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=fTBmg72UzrJzwwgyL0XX6MmGnq4XiN30FwOUg0WyeL8=; b=UHSrZ+8wNjpDSBoftKkaZUODEKQLv5sTHD3wN4eU4+0m6DxDPmiwQ03upT9hI9DMUt GJpNZz3FqtxD3vNK/PFRfFL5NwglfgskWUM6EotLnhYM5fQqyi2kE7nTZJlMbAOYz/N0 vzJhiaZZ48tFfHNJAvV2N2/U5GmKgdHCspqB+zT2q4FeKw4L2V+u5s+v5VCdZzlRquyb ywT7Vt/VeCk51GnHZO/qFsT5CsVuzv5gEf4171C6wRX7X6EcbT0U1MgBjGi5FOQVGfbH s2BWib18sHaAnSqdUYXFmA6bEvZqBZNW5+b1sMtMlEOzkEf5/ClnLyeYEDEG+WsDLqCE 4PBw== X-Gm-Message-State: AOAM530f+SSPlSOJJxTB6ajvnFBsfVcWn57K8GSsPexlMn9srl3qDaF4 KseFyCY+jVTFP5xdqyxcitVcI/I2hmmxSQSZp63DV/K70XUKl2aQ0G+KEq+aEWxlY624TtJvwGI peORMQdC2R9ulKwch1c4ftrFyKg== X-Received: by 2002:a17:90a:b016:: with SMTP id x22mr7315300pjq.205.1629699895443; Sun, 22 Aug 2021 23:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYnrO75usjjlrGCgZzdsLDtPE2dKORuqu4cQ6/SLHByjgTAawINCsTeerUMEDWc0TN8ooDAw== X-Received: by 2002:a17:90a:b016:: with SMTP id x22mr7315281pjq.205.1629699895193; Sun, 22 Aug 2021 23:24:55 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id g3sm14314416pfi.197.2021.08.22.23.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Aug 2021 23:24:54 -0700 (PDT) Subject: Re: [PATCH v11 01/12] iova: Export alloc_iova_fast() and free_iova_fast() To: Xie Yongji , mst@redhat.com, stefanha@redhat.com, sgarzare@redhat.com, parav@nvidia.com, hch@infradead.org, christian.brauner@canonical.com, rdunlap@infradead.org, willy@infradead.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, bcrl@kvack.org, corbet@lwn.net, mika.penttila@nextfour.com, dan.carpenter@oracle.com, joro@8bytes.org, gregkh@linuxfoundation.org, zhe.he@windriver.com, xiaodong.liu@intel.com, joe@perches.com, robin.murphy@arm.com Cc: songmuchun@bytedance.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210818120642.165-1-xieyongji@bytedance.com> <20210818120642.165-2-xieyongji@bytedance.com> From: Jason Wang Message-ID: <3ff77bab-8bb7-ae5b-4cf1-a90ebcc00118@redhat.com> Date: Mon, 23 Aug 2021 14:24:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210818120642.165-2-xieyongji@bytedance.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org ÔÚ 2021/8/18 ÏÂÎç8:06, Xie Yongji дµÀ: > Export alloc_iova_fast() and free_iova_fast() so that > some modules can make use of the per-CPU cache to get > rid of rbtree spinlock in alloc_iova() and free_iova() > during IOVA allocation. > > Signed-off-by: Xie Yongji Acked-by: Jason Wang (If we need respin, I'd suggest to put the numbers you measured here) Thanks > --- > drivers/iommu/iova.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c > index b6cf5f16123b..3941ed6bb99b 100644 > --- a/drivers/iommu/iova.c > +++ b/drivers/iommu/iova.c > @@ -521,6 +521,7 @@ alloc_iova_fast(struct iova_domain *iovad, unsigned long size, > > return new_iova->pfn_lo; > } > +EXPORT_SYMBOL_GPL(alloc_iova_fast); > > /** > * free_iova_fast - free iova pfn range into rcache > @@ -538,6 +539,7 @@ free_iova_fast(struct iova_domain *iovad, unsigned long pfn, unsigned long size) > > free_iova(iovad, pfn); > } > +EXPORT_SYMBOL_GPL(free_iova_fast); > > #define fq_ring_for_each(i, fq) \ > for ((i) = (fq)->head; (i) != (fq)->tail; (i) = ((i) + 1) % IOVA_FQ_SIZE)