From: bfields@fieldses.org
To: "Robert Rappaport" <robert.rappaport@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
"Wendy Cheng" <wcheng@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: File system awareness (or lack thereof) of vfs granting of leases
Date: Tue, 20 Feb 2007 16:14:16 -0500 (EST) [thread overview]
Message-ID: <40575.141.211.133.169.1172006056.squirrel@www.fieldses.org> (raw)
In-Reply-To: <f0a71180702201108h478e3b68v24049dc3c00f7dc7@mail.gmail.com>
"Robert Rappaport" <robert.rappaport@gmail.com> said:
> After looking more carefully at your changes, I have a question. Why
> didn't you modify the linux kernel routine, setlease(), so that it
> would either call f_op->set_lease() or __setlease()? Instead you
> created a new routine, nfs4_setlease(), and you modified the previous
> calls to setlease() in nfs4 to now call nfs4_setlease.
No good reason that I can see. I think you're correct that the
->setlease() call should go into the common code, and by invoked by fcntl
too.
--b.
next prev parent reply other threads:[~2007-02-20 21:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 23:51 File system awareness (or lack thereof) of vfs granting of leases Robert Rappaport
2007-02-17 5:32 ` Wendy Cheng
2007-02-18 6:39 ` J. Bruce Fields
2007-02-20 15:46 ` Robert Rappaport
2007-02-20 16:33 ` J. Bruce Fields
2007-02-20 19:08 ` Robert Rappaport
2007-02-20 21:14 ` bfields [this message]
2007-02-20 21:57 ` Robert Rappaport
2007-02-20 19:08 ` David Teigland
2007-02-20 20:51 ` bfields
2007-02-20 20:55 ` bfields
2007-02-20 21:25 ` David Teigland
2007-02-22 21:58 ` J. Bruce Fields
2007-02-22 22:57 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40575.141.211.133.169.1172006056.squirrel@www.fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=robert.rappaport@gmail.com \
--cc=wcheng@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).