From mboxrd@z Thu Jan  1 00:00:00 1970
From: bfields@fieldses.org
Subject: Re: File system awareness (or lack thereof) of vfs granting of
     leases
Date: Tue, 20 Feb 2007 16:14:16 -0500 (EST)
Message-ID: <40575.141.211.133.169.1172006056.squirrel@www.fieldses.org>
References: <f0a71180702161551p62a35dd7k27fefb4ab4092f81@mail.gmail.com>
    <45D6937A.10902@redhat.com> <20070218063948.GC22022@fieldses.org>
    <f0a71180702200746k6da1db84sb6d8da19189e1dc0@mail.gmail.com>
    <20070220163339.GA342@fieldses.org>
    <f0a71180702201108h478e3b68v24049dc3c00f7dc7@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	"Wendy Cheng" <wcheng@redhat.com>, linux-fsdevel@vger.kernel.org
To: "Robert Rappaport" <robert.rappaport@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.fieldses.org ([66.93.2.214]:58333 "EHLO fieldses.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1030412AbXBTVOT (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 20 Feb 2007 16:14:19 -0500
In-Reply-To: <f0a71180702201108h478e3b68v24049dc3c00f7dc7@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

"Robert Rappaport" <robert.rappaport@gmail.com> said:
> After looking more carefully at your changes, I have a question.  Why
> didn't you modify the linux kernel routine, setlease(), so that it
> would either call f_op->set_lease() or __setlease()?  Instead you
> created a new routine, nfs4_setlease(), and you modified the previous
> calls to setlease() in nfs4 to now call nfs4_setlease.

No good reason that I can see.  I think you're correct that the
->setlease() call should go into the common code, and by invoked by fcntl
too.

--b.