From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Reiser Subject: Re: silent semantic changes with reiser4 Date: Wed, 25 Aug 2004 11:28:56 -0700 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <412CDA68.7050702@namesys.com> References: <20040824202521.GA26705@lst.de> <412BA741.4060006@pobox.com> <20040824205343.GE21964@parcelfarce.linux.theplanet.co.uk> <20040824212232.GF21964@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , Christoph Hellwig , akpm@osdl.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Garzik , Reiserfs developers mail-list Return-path: Received: from rwcrmhc12.comcast.net ([216.148.227.85]:687 "EHLO rwcrmhc12.comcast.net") by vger.kernel.org with ESMTP id S268197AbUHYS3B (ORCPT ); Wed, 25 Aug 2004 14:29:01 -0400 To: viro@parcelfarce.linux.theplanet.co.uk In-Reply-To: <20040824212232.GF21964@parcelfarce.linux.theplanet.co.uk> List-Id: linux-fsdevel.vger.kernel.org I allowed myself to get talked out of a final top to bottom code audit, and obviously that was a mistake. It will probably take about 6 weeks. Apologies for wasting your time before that was done. Hans viro@parcelfarce.linux.theplanet.co.uk wrote: >On Tue, Aug 24, 2004 at 09:53:44PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote: > > > >>Feh. That's far from the worst parts of the mess introduced by "hybrid" >>crap - trivial sys_link(2) deadlocks triggerable by any user rate a bit >>higher on the suckitude scale, IMO. >> >> > >While we are at it - consider these hybrids vetoed until > a) sys_link()/sys_link() deadlock is fixed > b) sys_link()/sys_rename() deadlock is fixed > c) correctness proof of the locking scheme (in >Documentation/filesystems/directory-locking) is updated to match the >presense of the file/directory hybrids. > >Rationale: (a) and (b) - immediately exploitable by any user, (c) - "convince >us that there's no more crap of that kind". IMO a reasonable request, seeing >that the first look at the patches in -mm4 had turned up two exploits in >that area, despite the *YEARS* of warnings about potential trouble and need >to be careful there (actually, I've given Hans too much credit and assumed >that link/link never happens since nobody would be dumb enough to provide >->link() method for non-directory inodes; turns out that somebody is dumb >enough and link/link is as exploitable as link/rename). >- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ > > > >