From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66B87190662 for ; Wed, 5 Mar 2025 16:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741192464; cv=none; b=Ku/LX/LO7rlwYA7SSK3BipKj351rJohesRUePXCYO4FbxIuqs5IwZ7IS/COe6EWHZsHiGNTEzv7eFQ26lHUBpGmR60Wa5XptDL8KavlqmpGfAuQuInwtinKLX89Wl8NYDTEkwQtBgHUalDtexEXKexp+CFyBHiiAg990endX0wE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741192464; c=relaxed/simple; bh=MvcvTZROJ3YamGgkejX20F8DFgN4bMQ5gW19e6QGox4=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=a3JSJmjqlL1ReKh1GfN07799OWkAbkGqX/mBJCsReZ5aALzpChkTDzWVk6+7IaRFMZkLpLjcBWYpMv5PbTeFZOE8umYpFLttQaTAxwFVRjl8NZoC6H7kwfhFe36pR87AnvlyEGfIRjk/VbuxHfy5KCbXY1gVPX+VVHQ+CLqS8Gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=D4L1Vsrp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="D4L1Vsrp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741192462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MXm3fOyBN0R7dMmHNgkn5/hPY8QOMikcdewS0mfYvqk=; b=D4L1Vsrpe+nPeSDX59yKaDDdhrniTwjYVw+A54NeplnYtY5zd2hgLHuSAGD6wI+gBmEaj+ b1aB65Qy4aqQqk2RxHvuzUVUcBzbb5BEgi1x8J4nPoUFPIYkou0R3JSdHMGmZmb5+xExwB NiLHHbd34LGaxLk3rXP9yIcqGm9zrE0= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-C-2xn6rMMuGyUpMotejvxw-1; Wed, 05 Mar 2025 11:34:11 -0500 X-MC-Unique: C-2xn6rMMuGyUpMotejvxw-1 X-Mimecast-MFC-AGG-ID: C-2xn6rMMuGyUpMotejvxw_1741192450 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F1E61180035C; Wed, 5 Mar 2025 16:34:09 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.32.200]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F089E18001F5; Wed, 5 Mar 2025 16:34:06 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3989572.1734546794@warthog.procyon.org.uk> References: <3989572.1734546794@warthog.procyon.org.uk> To: Alex Markuze , Viacheslav Dubeyko , Ilya Dryomov Cc: dhowells@redhat.com, Xiubo Li , Jeff Layton , ceph-devel@vger.kernel.org, netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org Subject: Is EOLDSNAPC actually generated? -- Re: Ceph and Netfslib Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4170996.1741192445.1@warthog.procyon.org.uk> Date: Wed, 05 Mar 2025 16:34:05 +0000 Message-ID: <4170997.1741192445@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Hi Alex, Slava, I'm looking at making a ceph_netfs_write_iter() to handle writing to ceph files through netfs. One thing I'm wondering about is the way ceph_write_iter() handles EOLDSNAPC. In this case, it goes back to retry_snap and renegotiates the caps (amongst other things). Firstly, does it actually need to do this? And, secondly, I can't seem to find anything that actually generates EOLDSNAPC (or anything relevant that generates ERESTART). Is it possible that we could get rid of the code that handles EOLDSNAPC? David