From mboxrd@z Thu Jan 1 00:00:00 1970 From: Badari Pulavarty Subject: Re: [RFC] ext3 writepages for writeback mode Date: Thu, 10 Feb 2005 19:06:18 -0800 Message-ID: <420C212A.6090800@us.ibm.com> References: <1108085493.20053.1191.camel@dyn318077bld.beaverton.ibm.com> <20050210175327.7b4a508b.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: ext2-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, sct@redhat.com Return-path: Received: from e33.co.us.ibm.com ([32.97.110.131]:41629 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S262093AbVBKDGT (ORCPT ); Thu, 10 Feb 2005 22:06:19 -0500 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j1B36IiK597456 for ; Thu, 10 Feb 2005 22:06:18 -0500 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay05.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j1B36HWE259546 for ; Thu, 10 Feb 2005 20:06:17 -0700 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j1B36H2t014074 for ; Thu, 10 Feb 2005 20:06:17 -0700 To: Andrew Morton In-Reply-To: <20050210175327.7b4a508b.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > Badari Pulavarty wrote: > >> Here is my first cut at adding writepages() support for >> ext3 writeback mode. > > > Looks sane from a brief scan. Well, not really.. mpage_writepages() could end up calling ext3_writeback_writepage() in "confused" case thro .. *ret = page->mapping->a_ops->writepage(page, wbc); which ends up doing nothing and leaves the page dirty, since there is journal handle started :( if (ext3_journal_current_handle()) goto out_fail; Ideas ? Thanks, Badari