From: Jane Chu <jane.chu@oracle.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
hughd@google.com, akpm@linux-foundation.org, willy@infradead.org,
brauner@kernel.org, djwong@kernel.org
Cc: p.raghav@samsung.com, da.gomez@samsung.com,
a.manzanares@samsung.com, dave@stgolabs.net,
yosryahmed@google.com, keescook@chromium.org, hare@suse.de,
kbusch@kernel.org, patches@lists.linux.dev,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 8/8] shmem: add support to customize block size on multiple PAGE_SIZE
Date: Fri, 21 Apr 2023 22:10:39 -0700 [thread overview]
Message-ID: <42169da4-f453-af92-1c1e-76e65346c4af@oracle.com> (raw)
In-Reply-To: <20230421214400.2836131-9-mcgrof@kernel.org>
On 4/21/2023 2:44 PM, Luis Chamberlain wrote:
[..]
> + /*
> + * We cap this to allow a block to be at least allowed to
> + * be allocated using the buddy allocator. That's MAX_ORDER
> + * pages. So 4 MiB on x86_64.
8 MiB? since MAX_ORDER is 11.
> + */
> + if (ctx->blocksize > (1 << (MAX_ORDER + PAGE_SHIFT)))
> + goto bad_value; > +
> + /* The blocksize must be a multiple of the page size so must be aligned */
> + if (!PAGE_ALIGNED(ctx->blocksize))
> + goto bad_value;
> + break;
> }
> return 0;
-jane
prev parent reply other threads:[~2023-04-22 5:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 21:43 [RFC 0/8] shmem: add support for blocksize > PAGE_SIZE Luis Chamberlain
2023-04-21 21:43 ` [RFC 1/8] shmem: replace BLOCKS_PER_PAGE with PAGE_SECTORS Luis Chamberlain
2023-04-21 21:43 ` [RFC 2/8] shmem: convert to use folio_test_hwpoison() Luis Chamberlain
2023-04-21 22:42 ` Matthew Wilcox
2023-04-22 3:05 ` Luis Chamberlain
2023-04-24 21:17 ` Yang Shi
2023-04-24 21:36 ` Matthew Wilcox
2023-04-24 23:05 ` Yang Shi
[not found] ` <CGME20230425110913eucas1p22cf9d4c7401881999adb12134b985273@eucas1p2.samsung.com>
2023-04-25 11:00 ` Pankaj Raghav
2023-04-25 22:47 ` Luis Chamberlain
2023-04-26 7:43 ` Luis Chamberlain
2023-04-21 21:43 ` [RFC 3/8] shmem: account for high order folios Luis Chamberlain
2023-04-21 22:46 ` Matthew Wilcox
2023-04-21 21:43 ` [RFC 4/8] shmem: add helpers to get block size Luis Chamberlain
2023-04-21 22:49 ` Matthew Wilcox
2023-04-21 21:43 ` [RFC 5/8] shmem: account for larger blocks sizes for shmem_default_max_blocks() Luis Chamberlain
2023-04-21 21:43 ` [RFC 6/8] shmem: consider block size in shmem_default_max_inodes() Luis Chamberlain
2023-04-21 21:43 ` [RFC 7/8] shmem: add high order page support Luis Chamberlain
2023-04-21 21:44 ` [RFC 8/8] shmem: add support to customize block size on multiple PAGE_SIZE Luis Chamberlain
2023-04-22 5:10 ` Jane Chu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42169da4-f453-af92-1c1e-76e65346c4af@oracle.com \
--to=jane.chu@oracle.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=da.gomez@samsung.com \
--cc=dave@stgolabs.net \
--cc=djwong@kernel.org \
--cc=hare@suse.de \
--cc=hughd@google.com \
--cc=kbusch@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=patches@lists.linux.dev \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).