From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve French Subject: Re: AIO and vectored I/O support for cifs Date: Mon, 04 Apr 2005 00:43:50 -0500 Message-ID: <4250D416.9090606@austin.rr.com> References: <424481FF.5000006@austin.rr.com> <20050404052011.GA4114@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: hch@lst.de, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Return-path: Received: from ms-smtp-05.texas.rr.com ([24.93.47.44]:9365 "EHLO ms-smtp-05-eri0.texas.rr.com") by vger.kernel.org with ESMTP id S261218AbVDDFn7 (ORCPT ); Mon, 4 Apr 2005 01:43:59 -0400 To: suparna@in.ibm.com In-Reply-To: <20050404052011.GA4114@in.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Suparna Bhattacharya wrote: >cc'ing linux-aio, for the AIO part of the discussion. You might be able >to find some of your answers in the archives. > >there are several tests for AIO - I tend to use Chris Mason's aio-stress >which can be used to compare performance in terms of throughput for >streaming reads/writes for different variations of options. > >(the following page isn't exactly up-to-date, but should still give >you some pointers: lse.sf.net/io/aio.html) > > Thanks - those were lists that I was not aware of. >>You had mentioned do_sync_read - is there a reason to change the current >>call to generic_file_read in the cifs read entry point to do_sync_read. >>Some filesystems which export aio routines still call generic_file_read >>and others call do_sync_read and it was not obvious to me what that >>would change. >> >> > >I think you could keep it the way it is - generic_file_read will take care >of things. But maybe I should comment only after I see your patch. Are >you planning to post it some time ? > >Regards >Suparna > > This went in with the patch http://cifs.bkbits.net:8080/linux-2.5cifs/gnupatch@424470a3SsdVpix9tJE4NDebxqyRSg and merged into mainline about six days ago (note that it is disabled by default - unless CONFIG_CIFS_EXPERIMENTAL is selected).