From: Janak Desai <janak@us.ibm.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][patch 1/2] new system call, unshare
Date: Wed, 11 May 2005 08:11:59 -0400 [thread overview]
Message-ID: <4281F68F.9040508@us.ibm.com> (raw)
In-Reply-To: <20050510194422.4068.qmail@lwn.net>
Jonathan Corbet wrote:
> Janak Desai <janak@us.ibm.com> wrote:
>
>
>>+asmlinkage long sys_unshare(unsigned long unshare_flags)
>>+{
>>[...]
>>
>>+ if (!(unshare_flags & (CLONE_NEWNS | CLONE_VM | CLONE_SIGHAND)))
>>+ goto bad_unshare_invalid_val;
>
>
> If I read this function correctly, it will silently ignore any flags
> other than the three above, as long as at least one of those three is
> present. It might be a good idea to fail the call if any unrecognized
> flags are present or you risk changing application behavior in the
> future if any new flags are added.
>
Ok, thanks Jonathan. I will update the patch accordingly.
-Janak
prev parent reply other threads:[~2005-05-11 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 13:08 [RFC][patch 1/2] new system call, unshare Janak Desai
2005-05-10 19:44 ` Jonathan Corbet
2005-05-11 12:11 ` Janak Desai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4281F68F.9040508@us.ibm.com \
--to=janak@us.ibm.com \
--cc=corbet@lwn.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).