From: Jeff Mahoney <jeffm@suse.com>
To: Dave Chinner <dgc@sgi.com>
Cc: Hans Reiser <reiser@namesys.com>, fs <fs@ercist.iscas.ac.cn>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
viro VFS <viro@parcelfarce.linux.theplanet.co.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
zhiming@admin.iscas.ac.cn, qufuping@ercist.iscas.ac.cn,
madsys@ercist.iscas.ac.cn, xuh@nttdata.com.cn,
koichi@intellilink.co.jp, kuroiwaj@intellilink.co.jp,
okuyama@intellilink.co.jp, matsui_v@valinux.co.jp,
kikuchi_v@valinux.co.jp, fernando@intellilink.co.jp,
kskmori@intellilink.co.jp, takenakak@intellilink.co.jp,
yamaguchi@intellilink.co.jp, ext2-devel@lists.sourceforge.net,
sct@redhat.com, shaggy@austin.ibm.com, linux-xfs@oss.sgi.com,
Reiserfs developers mail-list <Reiserfs-Dev@namesys.com>
Subject: Re: [RFD] FS behavior (I/O failure) in kernel summit
Date: Thu, 16 Jun 2005 11:21:11 -0400 [thread overview]
Message-ID: <42B198E7.80100@suse.com> (raw)
In-Reply-To: <20050616121822.E125706@melbourne.sgi.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Dave Chinner wrote:
>>Well it seems to me that all the XFS code does is check to see if the FS
>>is in a shutdown state really early in the call path.
>
> FYI, the up front checks in XFS are simply to stop new I/O from starting
> if we're already in the shutdown state.
>
> However, there's more than that in XFS - there's checks all through
> it's I/O paths so that I/Os and transactions in flight at (or
> started after) the time of the shutdown can be aborted before doing
> further damage to a potentially corrupted filesystem. This part
> cannot be done generically as it is intimately tied to the
> filesystem.
>
> It is also worth noting that XFS won't shutdown a filesystem on just
> any I/O error. Shutdowns due to I/O errors only occur when the
> failure has the potential to leave the filesystem in an inconsistent
> state. Hence any given operation can return different errors
> depending on where the I/O error occurred in XFS and what effect
> that I/O error has on the consistency of the filesystem.....
Sorry, I should have clarified. I was only refering to the handling of
operations that aren't already in flight.
Currently, ReiserFS (and ext3) will set the filesystem read-only on
error, which ends up returning -EROFS in situations where that error
code is correct, but not entirely appropriate.
- -Jeff
- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCsZjnLPWxlyuTD7IRAuk5AKCplbYsl3YFml9/M1GRtuvBz21jvwCgoWKn
Mpl0khchSkQ1RwI/mkZ8buY=
=DxvJ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2005-06-16 15:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-13 19:53 [RFD] FS behavior (I/O failure) in kernel summit fs
2005-06-13 17:59 ` Hans Reiser
2005-06-13 20:13 ` [Ext2-devel] " Andreas Dilger
2005-06-13 23:56 ` Hans Reiser
2005-06-14 2:46 ` Kenichi Okuyama
2005-06-15 14:01 ` [Ext2-devel] " Theodore Ts'o
2005-06-15 19:40 ` Kenichi Okuyama
2005-06-15 20:37 ` [Ext2-devel] " Theodore Ts'o
2005-06-15 20:38 ` Hans Reiser
2005-06-15 22:53 ` Theodore Ts'o
2005-06-16 19:08 ` [Ext2-devel] " Hans Reiser
2005-06-16 11:52 ` Helge Hafting
2005-06-16 19:52 ` Hans Reiser
2005-06-16 21:27 ` Pavel Machek
2005-06-16 11:38 ` Matthew Wilcox
2005-06-14 12:51 ` Erik Mouw
2005-06-14 13:48 ` Denis Vlasenko
2005-06-14 17:16 ` Kenichi Okuyama
2005-06-14 20:17 ` Szakacsits Szabolcs
2005-06-14 3:46 ` Valdis.Kletnieks
2005-06-14 17:41 ` [Ext2-devel] " fs
2005-06-13 21:51 ` Jeff Mahoney
2005-06-14 0:03 ` Hans Reiser
2005-06-15 17:39 ` Jeff Mahoney
2005-06-16 2:18 ` Dave Chinner
2005-06-16 15:21 ` Jeff Mahoney [this message]
2005-06-16 18:52 ` Hans Reiser
2005-06-14 13:22 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B198E7.80100@suse.com \
--to=jeffm@suse.com \
--cc=Reiserfs-Dev@namesys.com \
--cc=akpm@osdl.org \
--cc=dgc@sgi.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=fernando@intellilink.co.jp \
--cc=fs@ercist.iscas.ac.cn \
--cc=kikuchi_v@valinux.co.jp \
--cc=koichi@intellilink.co.jp \
--cc=kskmori@intellilink.co.jp \
--cc=kuroiwaj@intellilink.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=madsys@ercist.iscas.ac.cn \
--cc=matsui_v@valinux.co.jp \
--cc=okuyama@intellilink.co.jp \
--cc=qufuping@ercist.iscas.ac.cn \
--cc=reiser@namesys.com \
--cc=sct@redhat.com \
--cc=shaggy@austin.ibm.com \
--cc=takenakak@intellilink.co.jp \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=xuh@nttdata.com.cn \
--cc=yamaguchi@intellilink.co.jp \
--cc=zhiming@admin.iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).