From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: linux-fsdevel@vger.kernel.org, DengChao <chao.deng@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs:affs:Replace time_t with time64_t
Date: Thu, 12 Nov 2015 14:45:28 +0100 [thread overview]
Message-ID: <4312946.SmG7PJzsvD@wuerfel> (raw)
In-Reply-To: <1447335641-14768-1-git-send-email-chao.deng@linaro.org>
On Thursday 12 November 2015 21:40:41 DengChao wrote:
> The affs code uses "time_t" and "get_seconds()". This will cause
> problems on 32-bit architectures in 2038 when time_t overflows.
> This patch replaces them with "time64_t" and
> "ktime_get_real_seconds()". This patch introduces expensive 64-bit
> divsion in "secs_to_datestamp()", considering this function is not
> called so often, the cost should be acceptable.
>
> Signed-off-by: DengChao <chao.deng@linaro.org>
>
Looks good,
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Is anyone picking up patches for random unmaintained file systems,
or should we put it into the y2038 tree?
Arnd
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2015-11-12 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 13:40 [PATCH] fs:affs:Replace time_t with time64_t DengChao
2015-11-12 13:45 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-12-13 9:48 DengChao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4312946.SmG7PJzsvD@wuerfel \
--to=arnd@arndb.de \
--cc=chao.deng@linaro.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox