From: Jules Irenge <jbi.octave@gmail.com>
To: boqun.feng@gmail.com
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, Jules Irenge <jbi.octave@gmail.com>
Subject: [PATCH 08/11] fs_pin: Add missing annotation for pin_kill() definition
Date: Sun, 9 Feb 2020 22:45:02 +0000 [thread overview]
Message-ID: <431ee9914abbd46e929860bea5a7de7f5edc0a38.1581282103.git.jbi.octave@gmail.com> (raw)
In-Reply-To: <cover.1581282103.git.jbi.octave@gmail.com>
Sparse reports a warning at pin_kill()
warning: context imbalance in pin_kil() - unexpected unlock
The root cause is a missing annotation for pin_kill()
Add the missing annotation __releases(RCU)
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
fs/fs_pin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs_pin.c b/fs/fs_pin.c
index 47ef3c71ce90..972168453fba 100644
--- a/fs/fs_pin.c
+++ b/fs/fs_pin.c
@@ -27,7 +27,7 @@ void pin_insert(struct fs_pin *pin, struct vfsmount *m)
spin_unlock(&pin_lock);
}
-void pin_kill(struct fs_pin *p)
+void pin_kill(struct fs_pin *p) __releases(RCU)
{
wait_queue_entry_t wait;
--
2.24.1
next prev parent reply other threads:[~2020-02-09 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/11>
2020-02-09 22:24 ` [PATCH 00/11] Lock warning cleanup Jules Irenge
2020-02-09 22:44 ` [PATCH 07/11] fs_pin: Add missing annotation for pin_kill() declaration Jules Irenge
2020-02-09 22:45 ` Jules Irenge [this message]
2020-02-10 5:06 ` [PATCH 00/11] Lock warning cleanup Boqun Feng
2020-02-10 23:09 ` Jules Irenge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431ee9914abbd46e929860bea5a7de7f5edc0a38.1581282103.git.jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).