* clear uptodate in 2.6's discard_buffer()?
@ 2005-09-12 14:38 Eric Sandeen
0 siblings, 0 replies; only message in thread
From: Eric Sandeen @ 2005-09-12 14:38 UTC (permalink / raw)
To: linux-fsdevel
I was tracking down a problem in xfs, which led me to discover that
discard_buffer(), in my case called when truncating a file, does not
clear the Uptodate flag on the bh.
It looks like clearing Uptodate was removed fairly specifically in the
2.6 tree, long ago, as part of a much larger changeset:
http://linux.bkbits.net:8080/linux-2.6/cset@1.373.70.7?nav=index.html|src/|src/fs|related/fs/buffer.c
At first glance it seems odd to me that we would clear dirty, mapped,
req, new, and delay flags, and also NULL out the b_bdev, but leave
buffers marked as uptodate.
Is there a reason to leave the uptodate flag, or is this an oversight?
Thanks,
-Eric
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-12 14:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-12 14:38 clear uptodate in 2.6's discard_buffer()? Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).