From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve French Subject: Re: [RFC PATCH] cleaning up negative dentries when remote directory is changed Date: Thu, 24 Nov 2005 20:29:11 -0600 Message-ID: <438676F7.2090005@austin.rr.com> References: <438669D9.7060505@austin.rr.com> <1132883741.8985.24.camel@lade.trondhjem.org> <438671A7.4060809@austin.rr.com> <1132885081.8985.36.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from ms-smtp-03.texas.rr.com ([24.93.47.42]:46841 "EHLO ms-smtp-03-eri0.texas.rr.com") by vger.kernel.org with ESMTP id S1161091AbVKYC2j (ORCPT ); Thu, 24 Nov 2005 21:28:39 -0500 To: Trond Myklebust In-Reply-To: <1132885081.8985.36.camel@lade.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Trond Myklebust wrote: > Nope. The d_revalidate() dentry operation is the right place to do this. > There is nothing in the VFS that special-cases revalidation of negative > dentries, so d_revalidate() will indeed be called whenever a cached > entry is looked up. > > AFAICS, the reason why CIFS fails to do this is that you have not > initialised dentry->d_op on the negative dentry. IOW: CIFS negative > dentries currently don't have a d_revalidate()... > > Cheers, > Trond > > > Argh ... It looks you are probably right, I am trying adding the dentry ops to negative dentries. I like it when there are obvious reasons for strange behavior. Thanks.