From: "J. R. Okajima" <hooanon05@yahoo.co.jp>
To: Trond.Myklebust@netapp.com
Cc: linux-fsdevel@vger.kernel.org
Subject: Q. NFS, return value of close(2)
Date: Thu, 12 Aug 2010 00:36:29 +0900 [thread overview]
Message-ID: <4387.1281540989@jrobl> (raw)
By the commit af7fa16 "NFS: Fix up the fsync code", close(2) seems to
return the non-zero value even if it goes well, eg. the number of page via
nfs_file_flush()
vfs_fsync()
nfs_file_fsync()
nfs_commit_inode()
nfs_scan_commit()
nfs_scan_list()
Should nfs_file_fsync() return 0 when "status" is positive?
{
status = nfs_commit_inode(inode, FLUSH_SYNC);
;;;
- if (!ret)
+ if (!ret && status < 0)
ret = status;
}
J. R. Okajima
next reply other threads:[~2010-08-11 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 15:36 J. R. Okajima [this message]
2010-08-11 16:31 ` Q. NFS, return value of close(2) Trond Myklebust
2010-08-11 17:04 ` J. R. Okajima
2010-08-11 17:06 ` Trond Myklebust
2010-08-13 12:25 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4387.1281540989@jrobl \
--to=hooanon05@yahoo.co.jp \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).