From: Steve French <smfrench@austin.rr.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: inode_change_ok
Date: Mon, 28 Nov 2005 11:48:35 -0600 [thread overview]
Message-ID: <438B42F3.1040006@austin.rr.com> (raw)
Why are there no calls to inode_change_ok in nfs (on the client), but
there are in most other filesytsems? Seems like there are some cases
in nfs in which a local permission check is done via a call to
nfs_permission which calls generic_permission ... if that is the case
why not do a call to inode_change_ok in similar cases?
For the case of cifs vfs, which is also missing this call - I was
thinking of adding something like:
if (!cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_PERM)
inode_change_ok(direntry->d_inode, attrs);
to fs/cifs/inode.c near the beginning of cifs_setattr. Although the
permissions (actually ACLs) are checked on the server during setattr
from cifs to Samba or cifs servers such as Windows, it is common for
convenience for users to mount with one id, rather than authenticating
each user (so that there are multiple smb uids) in which case the
permission check on setattr on the client can be important since
apparently the ".permission" entry point does not seem to get invoked in
the chown/chmod path.
next reply other threads:[~2005-11-28 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-28 17:48 Steve French [this message]
2005-11-28 17:06 ` inode_change_ok Trond Myklebust
2005-11-28 17:15 ` inode_change_ok Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438B42F3.1040006@austin.rr.com \
--to=smfrench@austin.rr.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).