From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Phillips <phillips@google.com>
Subject: Re: [RFC][PATCH] map multiple blocks at a time in mpage_readpages()
Date: Tue, 14 Feb 2006 15:30:22 -0800
Message-ID: <43F2680E.7060306@google.com>
References: <1139939347.4762.18.camel@dyn9047017100.beaverton.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: christoph <hch@lst.de>, akpm@osdl.org, mcao@us.ibm.com,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp-out.google.com ([216.239.45.12]:45069 "EHLO
	smtp-out.google.com") by vger.kernel.org with ESMTP
	id S1422856AbWBNXax (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 14 Feb 2006 18:30:53 -0500
To: Badari Pulavarty <pbadari@us.ibm.com>
In-Reply-To: <1139939347.4762.18.camel@dyn9047017100.beaverton.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Badari Pulavarty wrote:
> +		for (i = 0; ; i++) {
> +			if (i == nblocks) {
> +				*map_valid = 0;
> +				break;
> +			} else if (page_block == blocks_per_page)
> +				break;
> +			blocks[page_block] = map_bh->b_blocknr + i;
> +			page_block++;
> +			block_in_file++;
> +		}

Hi Badari, a tiny nit:

		for (i = 0; ; i++) {
			if (i == nblocks) {
				*map_valid = 0;
				break;
			}
			if (page_block == blocks_per_page)
				break;
			blocks[page_block] = map_bh->b_blocknr + i;
			page_block++;
			block_in_file++;
		}

Regards,

Daniel