From: "Arnd Bergmann" <arnd@arndb.de>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Miklos Szeredi" <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: uapi: use UAPI types
Date: Mon, 22 Dec 2025 09:54:08 +0100 [thread overview]
Message-ID: <43f1fd40-438a-4589-a6f5-7e044a9a3caa@app.fastmail.com> (raw)
In-Reply-To: <20251222-uapi-fuse-v1-1-85a61b87baa0@linutronix.de>
On Mon, Dec 22, 2025, at 09:06, Thomas Weißschuh wrote:
> Using libc types and headers from the UAPI headers is problematic as it
> introduces a dependency on a full C toolchain.
>
> Use the fixed-width integer types provided by the UAPI headers instead.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Please check the whitespace though:
> @@ -307,53 +303,53 @@ struct fuse_attr {
> * Linux.
> */
> struct fuse_sx_time {
> - int64_t tv_sec;
> - uint32_t tv_nsec;
> - int32_t __reserved;
> + __s64 tv_sec;
> + __u32 tv_nsec;
> + __s32 __reserved;
> };
This looks misaligned now, same for any other struct that
mixes signed and unsigned types, like fuse_open_out.
> @@ -1298,14 +1294,14 @@ enum fuse_uring_cmd {
> * In the 80B command area of the SQE.
> */
> struct fuse_uring_cmd_req {
> - uint64_t flags;
> + __u64 flags;
>
> /* entry identifier for commits */
> - uint64_t commit_id;
> + __u64 commit_id;
>
> /* queue the command is for (queue index) */
> - uint16_t qid;
> - uint8_t padding[6];
> + __u16 qid;
> + __u8 padding[6];
> };
Maybe also change this to use tab for alignment like all
the other structures.
Arnd
next prev parent reply other threads:[~2025-12-22 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 8:06 [PATCH] fuse: uapi: use UAPI types Thomas Weißschuh
2025-12-22 8:54 ` Arnd Bergmann [this message]
2025-12-22 10:10 ` Thomas Weißschuh
2025-12-22 21:16 ` Bernd Schubert
2025-12-23 8:37 ` Thomas Weißschuh
2025-12-23 9:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f1fd40-438a-4589-a6f5-7e044a9a3caa@app.fastmail.com \
--to=arnd@arndb.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox