From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Artem B. Bityutskiy" Subject: Re: [PATCH 5/13: eCryptfs] Header declarations Date: Thu, 04 May 2006 19:29:07 +0400 Message-ID: <445A1DC3.8040908@oktetlabs.ru> References: <20060504031755.GA28257@hellewell.homeip.net> <20060504033750.GD28613@hellewell.homeip.net> <84144f020605040751t2d2dca5ai4044f28d7118ee96@mail.gmail.com> <445A16B1.8080407@oktetlabs.ru> <1146756179.11422.8.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Phillip Hellewell , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, James Morris , "Stephen C. Tweedie" , Erez Zadok , David Howells Return-path: Received: from [84.204.75.166] ([84.204.75.166]:42894 "EHLO shelob.oktetlabs.ru") by vger.kernel.org with ESMTP id S1751507AbWEDP3I (ORCPT ); Thu, 4 May 2006 11:29:08 -0400 To: Pekka Enberg In-Reply-To: <1146756179.11422.8.camel@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Pekka Enberg wrote: > Pekka Enberg wrote: > >>>So, what's wrong with BUG_ON? > >>I guess because this may be compiled off when no debugging/extra >>checking is needed. > > But you shouldn't write assertions that you don't really need anyway. > I wouldn't be so strict. Normally, you don't need them and disable as they slow you down. But when you are hunting a problem you enable them as they may catch it on an early stage. I don't see anything bad here... -- Best regards, Artem B. Bityutskiy Oktet Labs (St. Petersburg), Software Engineer. +7 812 4286709 (office) +7 911 2449030 (mobile) E-mail: dedekind@oktetlabs.ru, Web: www.oktetlabs.ru