From mboxrd@z Thu Jan 1 00:00:00 1970 From: ProfiHost - Stefan Priebe Subject: XFS / Quota Bug in 2.6.17.x and 2.6.18x Date: Thu, 27 Jul 2006 14:24:47 +0200 Message-ID: <44C8B08F.8020603@profihost.com> References: <44C8A5F1.7060604@profihost.com> <20060727120425.GB6825@martell.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com Return-path: Received: from server077.de-nserver.de ([62.27.12.245]:20898 "EHLO server077.de-nserver.de") by vger.kernel.org with ESMTP id S1750903AbWG0MYx (ORCPT ); Thu, 27 Jul 2006 08:24:53 -0400 To: nathans@sgi.com In-Reply-To: <20060727120425.GB6825@martell.zuzino.mipt.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hello! The crash only occurs if you use quota and an IDE Drive without barrier= =20 support. The Problem is, that on a new mount of a root filesystem - the flag=20 VFS_RDONLY is set - and so no barrier check is done before checking=20 quota. With this patch barrier check is done always. The partition=20 should not be mounted at that moment, so it could not be READ ONLY. For= =20 mount -o remount, rw or something like this - XFS uses another function= =20 where VFS_RDONLY is checked. Error Message: ns2 Wed Jul 26 14:22:58 2006 "I/O error in filesystem ("hda6") meta-dat= a dev hda6 block 0x23db5ab ("xlog_iodone") error 5 buf count 1024" ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x2) called from = line 959 of file fs/xfs/xfs_log.c. Return address =3D 0xc0211535" ns2 Wed Jul 26 14:22:58 2006 "Filesystem "hda6": Log I/O Error Detected= =2E Shutting down filesystem: hda6" ns2 Wed Jul 26 14:22:58 2006 "Please umount the filesystem, and rectify= the problem(s)" ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x1) called from = line 338 of file fs/xfs/xfs_rw.c. Return address =3D 0xc0211535" ns2 Wed Jul 26 14:22:58 2006 "xfs_force_shutdown(hda6,0x1) called from = line 338 of file fs/xfs/xfs_rw.c. Return address =3D 0xc0211535" Patch: --- fs/xfs/xfs_vfsops.c.orig 2006-07-27 14:22:25.185949750 +0200 +++ fs/xfs/xfs_vfsops.c 2006-07-27 14:22:28.246141000 +0200 @@ -523,7 +523,7 @@ xfs_mount( if (error) goto error2; - if ((mp->m_flags & XFS_MOUNT_BARRIER) && !(vfsp->vfs_flag &=20 VFS_RDONLY)) + if (mp->m_flags & XFS_MOUNT_BARRIER) xfs_mountfs_check_barriers(mp); error =3D XFS_IOINIT(vfsp, args, flags); Best regards, Stefan Ihr ProfiHost Team ------------------------------------------ ProfiHost e.K. Lindener Str 15 38300 Wolfenb=FCttel Tel.: 05331 996890 =46ax: 05331 996899 URL: http://www.profihost.com E-Mail: support@profihost.com - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html