From mboxrd@z Thu Jan 1 00:00:00 1970 From: Badari Pulavarty Subject: Re: [PATCH 1/5] Forking ext4 filesystem from ext3 filesystem Date: Thu, 10 Aug 2006 11:51:34 -0700 Message-ID: <44DB8036.5020706@us.ibm.com> References: <1155172622.3161.73.camel@localhost.localdomain> <20060809233914.35ab8792.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cmm@us.ibm.com, linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:36038 "EHLO e5.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1161155AbWHJSvk (ORCPT ); Thu, 10 Aug 2006 14:51:40 -0400 To: Andrew Morton In-Reply-To: <20060809233914.35ab8792.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > Also, JBD is presently feeding into submit_bh() buffer_heads which span two > machine pages, and some device drivers spit the dummy. It'd be better to > fix that once, rather than twice.. > Andrew, I looked at this few days ago. I am not sure how we end up having multiple pages (especially, why we end up having buffers with bh_size > pagesize) ? Do you know why ? Easiest fix would be to fix submit_bh() to deal with multiple vecs - which is vetoed by Jens and I agree with him :( Thanks, Badari