From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Subject: Re: [PATCH 2/9] sector_t format string Date: Thu, 10 Aug 2006 16:17:35 -0400 Message-ID: <44DB945F.5080102@suse.com> References: <1155172843.3161.81.camel@localhost.localdomain> <20060809234019.c8a730e3.akpm@osdl.org> <20060810191747.GL20581@ca-server1.us.oracle.com> <20060810194440.GA6845@martell.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, cmm@us.ibm.com, linux-kernel@vger.kernel.org Return-path: To: Alexey Dobriyan In-Reply-To: <20060810194440.GA6845@martell.zuzino.mipt.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alexey Dobriyan wrote: > On Thu, Aug 10, 2006 at 12:17:47PM -0700, Joel Becker wrote: >> On Wed, Aug 09, 2006 at 11:40:19PM -0700, Andrew Morton wrote: >>> On Wed, 09 Aug 2006 18:20:43 -0700 >>> Mingming Cao wrote: >>> >>>> Define SECTOR_FMT to print sector_t in proper format >>> We've thus-far avoided doing this. In fact a similar construct in >>> device-mapper was recently removed. >> Yeah, OCFS2 had similar formats, and we were asked to change >> them to naked casts before inclusion. Seems quite consistent with the >> rest of the kernel. > > Will > > printk("%S", sector_t); > > kill at least one kitten? I like the general idea. I think that having to cast every time you want to print a sector number is pretty gross. I had something more like %Su in mind, though. - -Jeff - -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFE25RfLPWxlyuTD7IRAshdAJ0dboV4trG1Pgy6P+sqPiV0bWabYQCgiZng FuaanX+K+jSTwlrapumR1XY= =jLoe -----END PGP SIGNATURE----- ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642