From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH 2/9] sector_t format string Date: Thu, 10 Aug 2006 21:11:13 -0500 Message-ID: <44DBE741.2080801@redhat.com> References: <1155172843.3161.81.camel@localhost.localdomain> <20060809234019.c8a730e3.akpm@osdl.org> <1155257941.4505.32.camel@dyn9047017069.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: To: cmm@us.ibm.com In-Reply-To: <1155257941.4505.32.camel@dyn9047017069.beaverton.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ext2-devel-bounces@lists.sourceforge.net Errors-To: ext2-devel-bounces@lists.sourceforge.net List-Id: linux-fsdevel.vger.kernel.org Mingming Cao wrote: > When we cleanup ext3 code to fix some "int" type block numbers to > "unsigned long" type to able to truely support 2^32 bit ext3 (otherwise > ext3 is limited to 2^31 blocks (8TB)), we had to go through a lot of > printk to modify the format string from %d to %lu. It's a pain. FWIW, ext3 still isn't 32-bit clean, in my testing. The types are ok but the code overflows them with arithmetic in some places. Look for patches from me soon ;-) -eric ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642