From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mingming Cao Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4 Date: Tue, 15 Aug 2006 16:19:01 -0700 Message-ID: <44E25665.1000702@us.ibm.com> References: <1155677232.11401@shark.he.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Pavel Machek , Alex Tomas , Andrew Morton , linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:31369 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1750808AbWHOXTG (ORCPT ); Tue, 15 Aug 2006 19:19:06 -0400 To: Randy Dunlap In-Reply-To: <1155677232.11401@shark.he.net> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Randy Dunlap wrote: > >>Hi! >> >> >>>> AM> - The existing comments could benefit from some rework by a >>>> AM> native English speaker. >>>> >>>>could someone assist here, please? >>> >>>See if this helps. >>>Patch applies on top of all ext4 patches from >>>http://ext2.sourceforge.net/48bitext3/patches/latest/. >> >>>--- linux-2618-rc4-ext4.orig/include/linux/ext4_fs_extents.h >>>+++ linux-2618-rc4-ext4/include/linux/ext4_fs_extents.h >>>@@ -22,29 +22,29 @@ >>> #include >>> >>> /* >>>- * with AGRESSIVE_TEST defined capacity of index/leaf blocks >>>- * become very little, so index split, in-depth growing and >>>- * other hard changes happens much more often >>>- * this is for debug purposes only >>>+ * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks >>>+ * becomes very small, so index split, in-depth growing and >>>+ * other hard changes happen much more often. >>>+ * This is for debug purposes only. >>> */ >>> #define AGRESSIVE_TEST_ >> >>Using _ for disabling is unusual/nasty. Can't we simply #undef it? > > > Yes, that's the right thing to do. > The ext4dev people should do that. :) > Okey, I will fixed that. thanks. > --- > ~Randy