* generic_file_llseek vs. remote_llseek
@ 2006-08-22 19:49 Steve French (smfltc)
2006-08-22 20:00 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Steve French (smfltc) @ 2006-08-22 19:49 UTC (permalink / raw)
To: linux-fsdevel
Now that generic_file_llseek locks the inode, do we need to have anyone
use remote_llseek?
Although remote_llseek is newer, it does a lock_kernel which seems
excessive, unless it has to do with
some isize_write race issue it is trying to avoid.
The cifs code would probably be fine with the change to the (presumably
faster) generic_file_llseek,
and perhas the nfs code as weel..
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: generic_file_llseek vs. remote_llseek
2006-08-22 19:49 generic_file_llseek vs. remote_llseek Steve French (smfltc)
@ 2006-08-22 20:00 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2006-08-22 20:00 UTC (permalink / raw)
To: Steve French (smfltc); +Cc: linux-fsdevel
On Tue, 2006-08-22 at 14:49 -0500, Steve French (smfltc) wrote:
> Now that generic_file_llseek locks the inode, do we need to have anyone
> use remote_llseek?
>
> Although remote_llseek is newer, it does a lock_kernel which seems
> excessive, unless it has to do with
> some isize_write race issue it is trying to avoid.
>
> The cifs code would probably be fine with the change to the (presumably
> faster) generic_file_llseek,
> and perhas the nfs code as weel..
NFS has issues with isize_write(). We can't use it 'cos it presupposes
that all size changes will occur under the inode->i_mutex.
Unfortunately, remote servers don't take our local inode->i_mutex.
Cheers,
Trond
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-22 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-22 19:49 generic_file_llseek vs. remote_llseek Steve French (smfltc)
2006-08-22 20:00 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).