From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shaya Potter <spotter@cs.columbia.edu>
Subject: Re: bug in nfs in 2.6.18-rc5?
Date: Thu, 31 Aug 2006 11:20:56 -0400
Message-ID: <44F6FE58.9020701@cs.columbia.edu>
References: <44F6F80F.1000202@cs.columbia.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, unionfs@fsl.cs.sunysb.edu
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1751655AbWHaPVA@vger.kernel.org>
To: linux-fsdevel@vger.kernel.org
In-Reply-To: <44F6F80F.1000202@cs.columbia.edu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Shaya Potter wrote:
> so I'm trying to use unionfs, cachefs and nfs, as cachefs is 2.6.18-rc5 
> right now, thats what I'm testing, but I hit an oops.
> 
> basically unionfs's lookup does a "lookup_one_len()" on the underlying fs.
> 
> lookup_one_len() calls __lookup_hash()
> 
> __lookup_hash() is called as "__lookup_hash(&this, base, NULL)"
> 
> now that NULL is important.  that's the nameidata entry of __lookup_hash()
> 
> __lookup_hash() ends up calling the underlying fs's lookup op, i.e. 
> nfs_lookup()
> 
> nfs_lookup() calls nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
> 
> see the bug? :)
> 
> This doesn't seem like a unionfs bug, as one should be able to call 
> lookup_one_len() on an NFS fs.

ok my "fix" is basically that nfs_reval_fsid() uses the nd->mnt to get 
to mnt->mnt_root.

I basically switched it to take a dentry and I call it as

nfs_reval_fsid(dentry->d_sb->s_root, dir.....)

have no clue if this is correct, but it doesn't oops anymore and seems 
to "work".