From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [RFC 0/5] dio: clean up completion phase of direct_io_worker() Date: Wed, 06 Sep 2006 09:46:18 -0700 Message-ID: <44FEFB5A.7060905@oracle.com> References: <20060905235732.29630.3950.sendpatchset@tetsuo.zabbo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:30874 "EHLO rgminet01.oracle.com") by vger.kernel.org with ESMTP id S1751661AbWIFQqk (ORCPT ); Wed, 6 Sep 2006 12:46:40 -0400 To: Jeff Moyer In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > This all looks good, the code is much easier to follow. What do you think > about making dio->result an unsigned quantity? It should never be negative > now that there is an io_error field. Yeah, that has always bugged me too. I considered renaming it 'issued', or something, as part of this patchset but thought we could do it later. While we're on this topic, I'm nervious that we increment it when do_direct_IO fails. It might be sound, but that we consider it the amount of work "transferred" for dio->end_io makes me want to make sure there aren't confusing corner cases here. - z