From: John Hubbard <jhubbard@nvidia.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 4/5] selftests/filesystems: create get_unique_mnt_id() helper
Date: Thu, 8 May 2025 19:52:36 -0700 [thread overview]
Message-ID: <44fad486-d376-4a01-adf5-e7f29facdcea@nvidia.com> (raw)
In-Reply-To: <a5f97646-379c-4146-9dd3-93dab9f6ba91@nvidia.com>
On 5/8/25 12:35 PM, John Hubbard wrote:
> On 5/8/25 4:44 AM, Amir Goldstein wrote:
>> On Thu, May 8, 2025 at 9:43 AM John Hubbard <jhubbard@nvidia.com> wrote:
>>> On 5/7/25 1:43 PM, Amir Goldstein wrote:
> ...
>> Is there a different way to express this build dependency?
>
> Yes, but first I need to reload the kselftest build story back into
> my head. I *almost* remember the answer offhand, but not quite! I'll
> pull down your branch, just a sec.
>
OK, I finally got a moment to remember this, and your approach is
exactly correct after all! So please feel free to add:
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-05-09 2:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 20:42 [PATCH 0/5] filesystems selftests cleanups Amir Goldstein
2025-05-07 20:42 ` [PATCH 1/5] selftests/filesystems: move wrapper.h out of overlayfs subdir Amir Goldstein
2025-05-08 7:31 ` John Hubbard
2025-05-07 20:42 ` [PATCH 2/5] selftests/fs/statmount: build with tools include dir Amir Goldstein
2025-05-08 7:30 ` John Hubbard
2025-05-08 11:36 ` Amir Goldstein
2025-05-08 19:30 ` John Hubbard
2025-05-08 20:29 ` Amir Goldstein
2025-05-09 10:57 ` Christian Brauner
2025-05-09 11:08 ` Amir Goldstein
2025-05-09 13:34 ` Amir Goldstein
2025-05-08 7:33 ` John Hubbard
2025-05-07 20:43 ` [PATCH 3/5] selftests/fs/mount-notify: " Amir Goldstein
2025-05-08 7:38 ` John Hubbard
2025-05-08 11:53 ` Amir Goldstein
2025-05-08 19:13 ` John Hubbard
2025-05-07 20:43 ` [PATCH 4/5] selftests/filesystems: create get_unique_mnt_id() helper Amir Goldstein
2025-05-08 7:43 ` John Hubbard
2025-05-08 11:44 ` Amir Goldstein
2025-05-08 19:35 ` John Hubbard
2025-05-09 2:52 ` John Hubbard [this message]
2025-05-07 20:43 ` [PATCH 5/5] selftests/filesystems: create setup_userns() helper Amir Goldstein
2025-05-08 7:52 ` John Hubbard
2025-05-08 12:08 ` Amir Goldstein
2025-05-09 10:54 ` Christian Brauner
2025-05-08 12:40 ` Amir Goldstein
2025-05-08 19:32 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44fad486-d376-4a01-adf5-e7f29facdcea@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).