From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] linux/magic.h for magic numbers Date: Sat, 09 Sep 2006 09:24:22 -0400 Message-ID: <4502C086.2080302@garzik.org> References: <20060909110245.GA9617@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@osdl.org Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:42979 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932170AbWIINYY (ORCPT ); Sat, 9 Sep 2006 09:24:24 -0400 To: Grzegorz Kulewski In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Grzegorz Kulewski wrote: > On Sat, 9 Sep 2006, Jeff Garzik wrote: >> An IRC discussion sparked a memory: most filesystems really don't >> need to put anything at all in include/linux. Excluding API-ish >> filesystems like procfs, just about the only filesystem symbols that >> get exported outside of __KERNEL__ are the *_SUPER_MAGIC symbols, >> and similar symbols. >> >> After seeing the useful attributes of linux/poison.h, I propose a >> similar linux/magic.h. > > But... if some patch changes this file (like adding new magic symbol) it > will cause large part of the kernel to rebuild without any good reason. No? No :) * The days when linux/fs.h included individual filesystem headers is long gone. Only the filesystems themselves typically include the linux/foo_fs*.h files these days. * It's not like we add new filesystems to the kernel very often. Jeff