From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE Date: Mon, 06 Nov 2006 17:15:27 -0600 Message-ID: <454FC20F.8040206@redhat.com> References: <454FAE0A.3070409@redhat.com> <20061106230547.GA29711@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([66.187.233.31]:14534 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1753667AbWKFXPg (ORCPT ); Mon, 6 Nov 2006 18:15:36 -0500 To: Christoph Hellwig , Eric Sandeen , Linux Kernel Mailing List , linux-fsdevel , Theodore Tso In-Reply-To: <20061106230547.GA29711@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Christoph Hellwig wrote: > On Mon, Nov 06, 2006 at 03:50:02PM -0600, Eric Sandeen wrote: >> so I would propose the following patch to make PAGE_CACHE_SIZE the default (again), >> and let filesystems which need something -else- do that on their own. > > I agree with the conclusion, but the patch is incomplete. You went down > all the way to find out what the fileystems do in this messages, so add > the hunks to override the defaults for non-standard filesystems to the > patch aswell to restore the pre-inode diet state. Well, agreed. I put 80% or more back to pre-patch state, but not all. :) So it's less broken with my patch than without, so at least it's moving forward. So... Ted's patches get in w/o fixing up all the other filesystems (left as an exercise to the patch reader) but mine can't? :) -Eric