From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH] make last_inode counter in new_inode 32-bit on kernels that offer x86 compatability Date: Tue, 07 Nov 2006 12:10:36 -0600 Message-ID: <4550CC1C.6050205@redhat.com> References: <20061106182222.GO27140@parisc-linux.org> <1162838843.12129.8.camel@dantu.rdu.redhat.com> <20061106202313.GA691@wohnheim.fh-wedel.de> <454FA032.1070008@redhat.com> <20061106211134.GB691@wohnheim.fh-wedel.de> <454FAAF8.8080707@redhat.com> <1162914966.28425.24.camel@dantu.rdu.redhat.com> <20061107172835.GB15629@wohnheim.fh-wedel.de> <20061107174217.GA29746@wohnheim.fh-wedel.de> <20061107175601.GB29746@wohnheim.fh-wedel.de> <20061107180127.GC29746@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jeff Layton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:17886 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S965684AbWKGSKn (ORCPT ); Tue, 7 Nov 2006 13:10:43 -0500 To: =?ISO-8859-1?Q?J=F6rn_Engel?= In-Reply-To: <20061107180127.GC29746@wohnheim.fh-wedel.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org J=F6rn Engel wrote: > And the last one is xfs_mapping_buftarg(). I am completely at a loss= =2E > As far as I can tell, inode allocated, partially initiated and - > leaked. Am I missing something? It's not leaked... the new inode's mapping is saved in the buftarg: btp->bt_mapping =3D mapping; and then eventually the inode is put/freed in xfs_free_buftarg(): iput(btp->bt_mapping->host); The inode's mapping itself is used in several places: File Function Line 0 xfs/linux-2.6/xfs_buf.h 84 struct address_spa= ce *bt_mapping; 1 xfs/linux-2.6/xfs_buf.c _xfs_buf_lookup_pages 345 struct address_spa= ce *mapping =3D bp->b_target->bt_mapping; 2 xfs/linux-2.6/xfs_buf.c xfs_buf_readahead 671 bdi =3D target->bt= _mapping->backing_dev_info; 3 xfs/linux-2.6/xfs_buf.c xfs_buf_lock 906 blk_run_address_sp= ace(bp->b_target->bt_mapping); 4 xfs/linux-2.6/xfs_buf.c xfs_buf_wait_unpin 978 blk_run_address_sp= ace(bp->b_target->bt_mapping); 5 xfs/linux-2.6/xfs_buf.c xfs_buf_iowait 1291 blk_run_address_sp= ace(bp->b_target->bt_mapping); 6 xfs/linux-2.6/xfs_buf.c xfs_free_buftarg 1451 iput(btp->bt_mappi= ng->host); 7 xfs/linux-2.6/xfs_buf.c xfs_mapping_buftarg 1545 btp->bt_mapping =3D= mapping; 8 xfs/linux-2.6/xfs_buf.c xfsbufd 1728 blk_run_address_sp= ace(target->bt_mapping); 9 xfs/linux-2.6/xfs_buf.c xfs_flush_buftarg 1801 blk_run_address_sp= ace(target->bt_mapping); -Eric - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html