From: Cedric Le Goater <clg@fr.ibm.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Containers <containers@lists.osdl.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] [PATCH 1/4] uid_ns: introduce inode uid check helper
Date: Thu, 09 Nov 2006 21:05:43 +0100 [thread overview]
Message-ID: <45538A17.2000501@fr.ibm.com> (raw)
In-Reply-To: <20061107041915.GB28706@sergelap.austin.ibm.com>
> @@ -184,7 +184,7 @@ int generic_permission(struct inode *ino
> {
> umode_t mode = inode->i_mode;
>
> - if (current->fsuid == inode->i_uid)
> + if (inode_task_same_uid(inode, current))
> mode >>= 6;
> else {
Looking at the source of the above code in the email, I get :
@@ -184,7 +184,7 @@ int generic_permission(struct inode *ino
{
umode_t mode =3D inode->i_mode;
=
- if (current->fsuid =3D=3D inode->i_uid)
+ if (inode_task_same_uid(inode, current))
mode >>=3D 6;
else {
Where are those ugly '=3D' coming from ? is it my mailer or do you
get them also ?
thanks,
C.
next prev parent reply other threads:[~2006-11-09 20:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 4:18 [RFC] [PATCH 0/4] uid_ns: introduction Serge E. Hallyn
2006-11-07 4:19 ` [RFC] [PATCH 1/4] uid_ns: introduce inode uid check helper Serge E. Hallyn
2006-11-09 20:05 ` Cedric Le Goater [this message]
2006-11-07 4:19 ` [RFC] [PATCH 2/4] uid_ns: replace inode->fsuid checks under fs/ Serge E. Hallyn
2006-11-07 4:20 ` [RFC] [PATCH 3/4] uid_ns: replace i_uid check in fs/namespace.c Serge E. Hallyn
2006-11-07 4:20 ` [RFC] [PATCH 4/4] uid_ns: Add filesystem uid checks Serge E. Hallyn
2006-11-08 0:52 ` [RFC] [PATCH 0/4] uid_ns: introduction Herbert Poetzl
2006-11-08 17:46 ` Trond Myklebust
2006-11-08 20:34 ` Eric W. Biederman
2006-11-08 21:27 ` Herbert Poetzl
2006-11-08 21:54 ` Serge E. Hallyn
2006-11-09 0:42 ` Herbert Poetzl
2006-11-09 13:26 ` Eric W. Biederman
2006-11-09 16:50 ` Serge E. Hallyn
2006-11-09 17:17 ` Herbert Poetzl
2006-11-09 17:35 ` Serge E. Hallyn
2006-11-09 20:12 ` Cedric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45538A17.2000501@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).