From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cedric Le Goater Subject: Re: [RFC] [PATCH 1/4] uid_ns: introduce inode uid check helper Date: Thu, 09 Nov 2006 21:05:43 +0100 Message-ID: <45538A17.2000501@fr.ibm.com> References: <20061107041814.GA28706@sergelap.austin.ibm.com> <20061107041915.GB28706@sergelap.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Containers , linux-fsdevel@vger.kernel.org Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:56984 "EHLO e32.co.us.ibm.com") by vger.kernel.org with ESMTP id S965546AbWKIUFr (ORCPT ); Thu, 9 Nov 2006 15:05:47 -0500 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e32.co.us.ibm.com (8.13.8/8.12.11) with ESMTP id kA9K5kZ1009787 for ; Thu, 9 Nov 2006 15:05:46 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kA9K5kkW293848 for ; Thu, 9 Nov 2006 13:05:46 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kA9K5jLl009385 for ; Thu, 9 Nov 2006 13:05:46 -0700 To: "Serge E. Hallyn" In-Reply-To: <20061107041915.GB28706@sergelap.austin.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > @@ -184,7 +184,7 @@ int generic_permission(struct inode *ino > { > umode_t mode = inode->i_mode; > > - if (current->fsuid == inode->i_uid) > + if (inode_task_same_uid(inode, current)) > mode >>= 6; > else { Looking at the source of the above code in the email, I get : @@ -184,7 +184,7 @@ int generic_permission(struct inode *ino { umode_t mode =3D inode->i_mode; = - if (current->fsuid =3D=3D inode->i_uid) + if (inode_task_same_uid(inode, current)) mode >>=3D 6; else { Where are those ugly '=3D' coming from ? is it my mailer or do you get them also ? thanks, C.