From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: Status of buffered write path (deadlock fixes) Date: Tue, 12 Dec 2006 03:39:54 +1100 Message-ID: <457D89DA.5010705@yahoo.com.au> References: <45751712.80301@yahoo.com.au> <20061207195518.GG4497@ca-server1.us.oracle.com> <4578DBCA.30604@yahoo.com.au> <20061208234852.GI4497@ca-server1.us.oracle.com> <457D20AE.6040107@yahoo.com.au> <457D7EBA.7070005@yahoo.com.au> <1165853552.3752.1015.camel@quoit.chygwyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark Fasheh , Linux Memory Management , linux-fsdevel@vger.kernel.org, linux-kernel , OGAWA Hirofumi , Andrew Morton Return-path: Received: from smtp106.mail.mud.yahoo.com ([209.191.85.216]:29917 "HELO smtp106.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S937065AbWLKQn4 (ORCPT ); Mon, 11 Dec 2006 11:43:56 -0500 To: Steven Whitehouse In-Reply-To: <1165853552.3752.1015.camel@quoit.chygwyn.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Steven Whitehouse wrote: >>Hmm, doesn't look like we can do this either because at least GFS2 >>uses BH_New for its own special things. >> > > What makes you say that? As far as I know we are not doing anything we > shouldn't with this flag, and if we are, then I'm quite happy to > consider fixing it up so that we don't, Bad wording. Many other filesystems seem to only make use of buffer_new between prepare and commit_write. gfs2 seems to at least test it in a lot of places, so it is hard to know whether we can change the current semantics or not. I didn't mean that gfs2 is doing anything wrong. So can we clear it in commit_write? -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com