From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write Date: Thu, 04 Jan 2007 16:51:58 +1100 Message-ID: <459C95FE.1090802@yahoo.com.au> References: <20061227153855.GA25898@in.ibm.com> <20061228082308.GA4476@in.ibm.com> <20070103141556.82db0e81.akpm@osdl.org> <20070104045621.GA8353@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-aio@kvack.org, drepper@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, jakub@redhat.com, mingo@elte.hu Return-path: Received: from smtp108.mail.mud.yahoo.com ([209.191.85.218]:29643 "HELO smtp108.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932278AbXADFwc (ORCPT ); Thu, 4 Jan 2007 00:52:32 -0500 To: suparna@in.ibm.com In-Reply-To: <20070104045621.GA8353@in.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Suparna Bhattacharya wrote: > On Wed, Jan 03, 2007 at 02:15:56PM -0800, Andrew Morton wrote: >>Plus Jens's unplugging changes add more reliance upon context inside >>*current, for the plugging and unplugging operations. I expect that the >>fsaio patches will need to be aware of the protocol which those proposed >>changes add. > > > Whatever logic applies to background writeout etc should also just apply > as is to aio worker threads, shouldn't it ? At least at a quick glance I > don't see anything special that needs to be done for fsaio, but its good > to be aware of this anyway, thanks ! The submitting process plugs itself, submits all its IO, then unplugs itself (ie. so the plug is now on the process, rather than the block device). So long as AIO threads do the same, there would be no problem (plugging is optional, of course). This (is supposed to) give a number of improvements over the traditional plugging (although some downsides too). Most notably for me, the VM gets cleaner ;) However AIO could be an interesting case to test for explicit plugging because of the way they interact. What kind of improvements do you see with samba and do you have any benchmark setups? Thanks, Nick -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com