From: Jeff Layton <jlayton@redhat.com>
To: Kirill Korotaev <dev@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] have pipefs ensure i_ino uniqueness by calling iunique and hashing the inode
Date: Fri, 26 Jan 2007 09:42:33 -0500 [thread overview]
Message-ID: <45BA1359.7020200@redhat.com> (raw)
In-Reply-To: <45B9F939.8070701@openvz.org>
Kirill Korotaev wrote:
> Jeff,
>
> is 100% uniqeness is so much required for pipe inode numbers?
> AFAIU, it is not that critical for pipefs (unlike smb, nfs etc.)
>
> Thanks,
> Kirill
>
There is no in-kernel reason why i_ino uniqueness is important for
pipefs. Where it might matter is userspace. The i_ino value is used for:
1) the st_ino value returned in stat calls
2) the dentry name (generated as "[inode_number]")
So while it's certainly not "correct" to have multiple inodes with the same
number on any filesystem, it is probably more important in some places is
others. For pipefs, maybe it isn't, especially given a potential 6% performance
impact to fix it. Anyone else have thoughts?
-- Jeff
next prev parent reply other threads:[~2007-01-26 14:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 19:11 [PATCH 3/3] have pipefs ensure i_ino uniqueness by calling iunique and hashing the inode Jeff Layton
2007-01-26 12:51 ` Kirill Korotaev
2007-01-26 14:42 ` Jeff Layton [this message]
2007-01-26 15:12 ` Eric Dumazet
2007-01-30 15:04 ` Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2007-01-08 20:47 Jeff Layton
2007-01-10 21:24 ` Christoph Hellwig
2007-01-16 18:57 Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BA1359.7020200@redhat.com \
--to=jlayton@redhat.com \
--cc=dev@openvz.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).