From: Phillip Susi <psusi@cfl.rr.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Mike Snitzer <snitzer@gmail.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: forced umount?
Date: Mon, 26 Mar 2007 17:34:49 -0400 [thread overview]
Message-ID: <46083C79.1080108@cfl.rr.com> (raw)
In-Reply-To: <84144f020703170353y4490d0dcr24352c291c96300b@mail.gmail.com>
Is this revoke system supported for the filesystem as a whole? I
thought it was just to force specific files closed, not the whole
filesystem. What if the filesystem itself has pending IO to say, update
inodes or block bitmaps? Can these be aborted?
Pekka Enberg wrote:
> FYI, the revoke implementation have since been changed to follow the
> badfs-style approach of the forced unmount patches. However, there are
> some problems with the forced unmount patches that are now fixed in
> the revoke implementation:
>
> - You can't use munmap() to take down shared memory mappings because the
> application can accidentally remap something completely different
> to that region.
> - The ->f_light bits slow down other fget_light() users and there's
> a race between
> fcheck_files() and set_f_light().
> - The operation can live-lock if a malicious process keeps forking. The
> revoke
> implementation solves this by revoking in two passes: (1) take
> down the descriptors
> and (2) take down the actual inodes.
>
> Pekka
next prev parent reply other threads:[~2007-03-26 21:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-17 4:06 forced umount? Mike Snitzer
2007-03-17 4:27 ` Jeremy Fitzhardinge
2007-03-17 5:37 ` Mike Snitzer
2007-03-17 10:53 ` Pekka Enberg
2007-03-26 21:34 ` Phillip Susi [this message]
2007-03-27 6:32 ` Pekka J Enberg
2007-03-28 14:46 ` Phillip Susi
2007-03-17 5:24 ` Gene Heskett
2007-03-18 19:16 ` Arjan van de Ven
2007-03-18 20:13 ` Matthew Wilcox
2007-03-18 23:45 ` Jan Engelhardt
2007-03-18 20:20 ` Mike Snitzer
2007-03-26 11:21 ` Pozsar Balazs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46083C79.1080108@cfl.rr.com \
--to=psusi@cfl.rr.com \
--cc=jeremy@goop.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=snitzer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).