From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: patch: VFS: fix passing of AT_PHDR value in auxv to ELF interpreter
Date: Fri, 04 May 2007 16:31:49 -0700
Message-ID: <463BC265.7050507@goop.org>
References: <20070504140921.GA23122@goelette.ens.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"David A. Madore" <David.Madore@ens.fr>,
	"Eric W. Biederman" <ebiederm@xmission.com>
To: Quentin Godfroy <godfroy@clipper.ens.fr>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from gw.goop.org ([64.81.55.164]:57536 "EHLO mail.goop.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754140AbXEDXbr (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 4 May 2007 19:31:47 -0400
In-Reply-To: <20070504140921.GA23122@goelette.ens.fr>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Quentin Godfroy wrote:
> +	elf_ppnt = elf_phdata;
> +	for (i = 0; i< loc->elf_ex.e_phnum; i++, elf_ppnt++)
> +		if (elf_ppnt->p_type == PT_PHDR) {
> +			phdr_addr = elf_ppnt->p_vaddr;
>   

Won't this break with ET_DYN executables?  And besides, isn't this the
same thing?  Shouldn't PT_PHDR->p_vaddr point to the vaddr of the Phdr
table itself?

    J