From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [PATCH 2/2] AFS: Implement shared-writable mmap Date: Wed, 16 May 2007 10:41:31 +1000 Message-ID: <464A533B.8040507@yahoo.com.au> References: <20070515155224.29345.22719.stgit@warthog.cambridge.redhat.com> <20070515155231.29345.6212.stgit@warthog.cambridge.redhat.com> <20070515144007.f87d9be5.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: David Howells , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Hugh Dickins To: Andrew Morton Return-path: Received: from smtp102.mail.mud.yahoo.com ([209.191.85.212]:37436 "HELO smtp102.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757392AbXEPAlk (ORCPT ); Tue, 15 May 2007 20:41:40 -0400 In-Reply-To: <20070515144007.f87d9be5.akpm@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > On Tue, 15 May 2007 16:52:31 +0100 > David Howells wrote: > > >>Implement shared-writable mmap for AFS. > > > This blows up in -mm: > > fs/afs/file.c:59: error: 'filemap_nopage' undeclared here (not in a function) > fs/afs/file.c:60: error: unknown field 'populate' specified in initializer > fs/afs/file.c:60: error: 'filemap_populate' undeclared here (not in a function) > > because Nick went and renamed half the VM and deleted the other half. And page_mkwrite is next ;) > I need to work out what to do with > > mm-fix-fault-vs-invalidate-race-for-linear-mappings.patch > mm-merge-populate-and-nopage-into-fault-fixes-nonlinear.patch > mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-doc-fix.patch > mm-merge-populate-and-nopage-into-fault-fixes-nonlinear-fix.patch > mm-merge-nopfn-into-fault.patch > convert-hugetlbfs-to-use-vm_ops-fault.patch > mm-remove-legacy-cruft.patch > mm-debug-check-for-the-fault-vs-invalidate-race.patch > mm-fix-clear_page_dirty_for_io-vs-fault-race.patch > > Probably merge them, I guess. Hugh had concerns, I think over small > additional overhead from the lock_page()? Yes he did. It seems to only be noticable in microbenchmarks. In my opinion not enough to withhold pagecache corruption bug fixes. Still, I have some lock_page speedup work that eliminates that regression anyway. However, Hugh hasn't exactly said yes or no yet... -- SUSE Labs, Novell Inc.